Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(387)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1054203002: Enable NeedsBraces check and fix some checkstyle issues. (Closed)

Created:
5 years, 8 months ago by aurimas (slooooooooow)
Modified:
5 years, 8 months ago
CC:
aboxhall+watch_chromium.org, android-webview-reviews_chromium.org, chromium-reviews, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, erikwright+watch_chromium.org, feature-media-reviews_chromium.org, jbudorick+watch_chromium.org, je_julie(Not used), klundberg+watch_chromium.org, mcasas+watch_chromium.org, nektar+watch_chromium.org, plundblad+watch_chromium.org, posciak+watch_chromium.org, wjia+watch_chromium.org, yfriedman+watch_chromium.org, yuzo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable NeedsBraces check and fix some checkstyle issues. NeedBraces will now check for {} in if, while, and for statements. It will still allow one line inline statements. BUG=None Committed: https://crrev.com/2827f2b320e8e00137fc6b6328f10edb229c1d4a Cr-Commit-Position: refs/heads/master@{#323823}

Patch Set 1 #

Total comments: 3

Patch Set 2 : Added if checks #

Unified diffs Side-by-side diffs Delta from patch set Stats (+133 lines, -133 lines) Patch
M android_webview/glue/java/src/com/android/webview/chromium/ResourcesContextWrapperFactory.java View 1 1 chunk +2 lines, -1 line 0 comments Download
M android_webview/glue/java/src/com/android/webview/chromium/WebViewContentsClientAdapter.java View 1 2 chunks +13 lines, -8 lines 0 comments Download
M android_webview/java/src/org/chromium/android_webview/AwAutofillClient.java View 1 1 chunk +1 line, -2 lines 0 comments Download
M android_webview/java/src/org/chromium/android_webview/AwContents.java View 1 2 chunks +3 lines, -1 line 0 comments Download
M android_webview/java/src/org/chromium/android_webview/AwContentsClient.java View 1 1 chunk +2 lines, -1 line 0 comments Download
M android_webview/java/src/org/chromium/android_webview/AwScrollOffsetManager.java View 1 2 chunks +2 lines, -4 lines 0 comments Download
M android_webview/java/src/org/chromium/android_webview/JsResultHandler.java View 1 2 chunks +2 lines, -4 lines 0 comments Download
M android_webview/java/src/org/chromium/android_webview/ScrollAccessibilityHelper.java View 1 2 chunks +2 lines, -4 lines 0 comments Download
M android_webview/java/src/org/chromium/android_webview/permission/AwPermissionRequest.java View 1 1 chunk +4 lines, -2 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/AndroidScrollIntegrationTest.java View 1 1 chunk +2 lines, -4 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/ArchiveTest.java View 1 1 chunk +1 line, -2 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientShouldInterceptRequestTest.java View 1 1 chunk +1 line, -2 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/HttpCacheTest.java View 1 1 chunk +1 line, -2 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/LoadUrlTest.java View 1 chunk +2 lines, -1 line 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/util/ImagePageGenerator.java View 1 chunk +2 lines, -2 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/util/JSUtils.java View 1 chunk +4 lines, -4 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/util/VideoSurfaceViewUtils.java View 1 1 chunk +3 lines, -4 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/util/VideoTestUtil.java View 1 1 chunk +2 lines, -1 line 0 comments Download
M android_webview/test/shell/src/org/chromium/android_webview/test/TestContentProvider.java View 2 chunks +3 lines, -3 lines 0 comments Download
M android_webview/unittestjava/src/org/chromium/android_webview/unittest/InputStreamUnittest.java View 1 1 chunk +3 lines, -2 lines 0 comments Download
M base/android/javatests/src/org/chromium/base/ObserverListTest.java View 4 chunks +4 lines, -8 lines 0 comments Download
M base/test/android/javatests/src/org/chromium/base/test/util/TestFileUtil.java View 2 chunks +8 lines, -8 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/WebappAuthenticator.java View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ContextMenuParams.java View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/cookies/CookiesFetcher.java View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/media/remote/LockScreenTransportControl.java View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/media/remote/LockScreenTransportControlV18.java View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/omnibox/SuggestionAnswer.java View 1 chunk +9 lines, -9 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabModelOrderController.java View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/widget/accessibility/AccessibilityTabModelAdapter.java View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/test/ModalDialogTest.java View 1 chunk +4 lines, -5 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/test/ProviderBookmarksUriTest.java View 3 chunks +6 lines, -6 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/test/ProviderSearchesUriTest.java View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/translate/TranslateInfoBarTest.java View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/android/shell/java/src/org/chromium/chrome/shell/omnibox/SuggestionPopup.java View 1 1 chunk +1 line, -2 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/accessibility/BrowserAccessibilityManager.java View 1 1 chunk +3 lines, -2 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java View 1 2 chunks +11 lines, -5 lines 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/MediaResourceGetterTest.java View 1 1 chunk +4 lines, -8 lines 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/ScreenOrientationListenerTest.java View 1 1 chunk +4 lines, -3 lines 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/TransitionTest.java View 1 1 chunk +2 lines, -1 line 0 comments Download
M content/public/test/android/javatests/src/org/chromium/content/browser/test/util/OrientationChangeObserverCriteria.java View 1 1 chunk +1 line, -2 lines 0 comments Download
M tools/android/checkstyle/chromium-style-5.0.xml View 1 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (4 generated)
aurimas (slooooooooow)
+boliu for android_webview/ +nyquist for base/ and chrome/android/ +newt for checkstyle xml change.
5 years, 8 months ago (2015-04-02 21:38:35 UTC) #2
boliu
On 2015/04/02 21:38:35, aurimas wrote: > +boliu for android_webview/ lgtm How much of this with ...
5 years, 8 months ago (2015-04-02 21:43:13 UTC) #3
nyquist
base/android, chrome/android lgtm. Was all those changes intentional by the way? You seemed to have ...
5 years, 8 months ago (2015-04-02 21:51:27 UTC) #4
aurimas (slooooooooow)
newt pointed out that I missed adding LITERAL_IF to the check. Please take another pass ...
5 years, 8 months ago (2015-04-02 22:31:55 UTC) #5
newt (away)
chrome/ lgtm
5 years, 8 months ago (2015-04-02 22:38:53 UTC) #6
aurimas (slooooooooow)
+dtrainor for content/public/android changes
5 years, 8 months ago (2015-04-03 20:42:01 UTC) #8
David Trainor- moved to gerrit
content/public/android lgtm
5 years, 8 months ago (2015-04-03 20:44:06 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1054203002/20001
5 years, 8 months ago (2015-04-03 20:47:03 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-03 21:44:13 UTC) #13
commit-bot: I haz the power
5 years, 8 months ago (2015-04-03 21:45:07 UTC) #14
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/2827f2b320e8e00137fc6b6328f10edb229c1d4a
Cr-Commit-Position: refs/heads/master@{#323823}

Powered by Google App Engine
This is Rietveld 408576698