chrome/android/java/src/org/chromium/chrome/browser/omnibox/SuggestionAnswer.java - Issue 1054203002: Enable NeedsBraces check and fix some checkstyle issues.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/omnibox/SuggestionAnswer.java

Issue 1054203002: Enable NeedsBraces check and fix some checkstyle issues. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added if checks Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/media/remote/LockScreenTransportControlV18.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabModelOrderController.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/omnibox/SuggestionAnswer.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/omnibox/SuggestionAnswer.java b/chrome/android/java/src/org/chromium/chrome/browser/omnibox/SuggestionAnswer.java

index efd5cfb8cb3d99ffc224738a6529a53d3f619422..a6eaff0cdc26847b9564e4a75196c187b468bc3d 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/omnibox/SuggestionAnswer.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/omnibox/SuggestionAnswer.java

@@ -106,17 +106,17 @@ public class SuggestionAnswer {

mTextFields.add(new TextField(textValues.getJSONObject(i)));

}

- mAdditionalText = jsonLine.has(ANSWERS_JSON_ADDITIONAL_TEXT) ?

- new TextField(jsonLine.getJSONObject(ANSWERS_JSON_ADDITIONAL_TEXT)) :

- null;

+ mAdditionalText = jsonLine.has(ANSWERS_JSON_ADDITIONAL_TEXT)

+ ? new TextField(jsonLine.getJSONObject(ANSWERS_JSON_ADDITIONAL_TEXT))

+ : null;

- mStatusText = jsonLine.has(ANSWERS_JSON_STATUS_TEXT) ?

- new TextField(jsonLine.getJSONObject(ANSWERS_JSON_STATUS_TEXT)) :

- null;

+ mStatusText = jsonLine.has(ANSWERS_JSON_STATUS_TEXT)

+ ? new TextField(jsonLine.getJSONObject(ANSWERS_JSON_STATUS_TEXT))

+ : null;

- mImage = jsonLine.has(ANSWERS_JSON_IMAGE) ?

- jsonLine.getJSONObject(ANSWERS_JSON_IMAGE).getString(ANSWERS_JSON_IMAGE_DATA) :

- null;

+ mImage = jsonLine.has(ANSWERS_JSON_IMAGE)

+ ? jsonLine.getJSONObject(ANSWERS_JSON_IMAGE).getString(ANSWERS_JSON_IMAGE_DATA)

+ : null;

}

/**