content/public/android/javatests/src/org/chromium/content/browser/ScreenOrientationListenerTest.java - Issue 1054203002: Enable NeedsBraces check and fix some checkstyle issues.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/android/javatests/src/org/chromium/content/browser/ScreenOrientationListenerTest.java

Issue 1054203002: Enable NeedsBraces check and fix some checkstyle issues. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added if checks Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/public/android/javatests/src/org/chromium/content/browser/MediaResourceGetterTest.java ('k') | content/public/android/javatests/src/org/chromium/content/browser/TransitionTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/android/javatests/src/org/chromium/content/browser/ScreenOrientationListenerTest.java

diff --git a/content/public/android/javatests/src/org/chromium/content/browser/ScreenOrientationListenerTest.java b/content/public/android/javatests/src/org/chromium/content/browser/ScreenOrientationListenerTest.java

index af0b0c226dee4cd4c55e2f55ab59b9dedf9b3b5a..1d1ebccd93963385a30411937a85430b5e95e0ee 100644

--- a/content/public/android/javatests/src/org/chromium/content/browser/ScreenOrientationListenerTest.java

+++ b/content/public/android/javatests/src/org/chromium/content/browser/ScreenOrientationListenerTest.java

@@ -45,11 +45,12 @@ public class ScreenOrientationListenerTest extends ContentShellTestBase {

case ActivityInfo.SCREEN_ORIENTATION_LANDSCAPE:

case ActivityInfo.SCREEN_ORIENTATION_REVERSE_PORTRAIT:

case ActivityInfo.SCREEN_ORIENTATION_REVERSE_LANDSCAPE:

- if (expectedOrientation == currentOrientation)

+ if (expectedOrientation == currentOrientation) {

return true;

- else if (ALLOW_0_FOR_180 && expectedOrientation == 180

- && currentOrientation == 0)

+ } else if (ALLOW_0_FOR_180 && expectedOrientation == 180

+ && currentOrientation == 0) {

return true;

+ }

return false;

default:

return false;