Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Side by Side Diff: tools/android/checkstyle/chromium-style-5.0.xml

Issue 1054203002: Enable NeedsBraces check and fix some checkstyle issues. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added if checks Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 <?xml version="1.0" encoding="UTF-8"?> 1 <?xml version="1.0" encoding="UTF-8"?>
2 <!DOCTYPE module PUBLIC "-//Puppy Crawl//DTD Check Configuration 1.3//EN" "http: //www.puppycrawl.com/dtds/configuration_1_3.dtd"> 2 <!DOCTYPE module PUBLIC "-//Puppy Crawl//DTD Check Configuration 1.3//EN" "http: //www.puppycrawl.com/dtds/configuration_1_3.dtd">
3 3
4 <!-- 4 <!--
5 See installation instructions: https://sites.google.com/a/chromium.org/dev/che ckstyle 5 See installation instructions: https://sites.google.com/a/chromium.org/dev/che ckstyle
6 --> 6 -->
7 <module name="Checker"> 7 <module name="Checker">
8 <property name="severity" value="warning"/> 8 <property name="severity" value="warning"/>
9 <property name="charset" value="UTF-8"/> 9 <property name="charset" value="UTF-8"/>
10 <module name="TreeWalker"> 10 <module name="TreeWalker">
(...skipping 83 matching lines...) Expand 10 before | Expand all | Expand 10 after
94 <property name="ignorePattern" value="^package.*|^import.*|a href|href|htt p://|https://|ftp://"/> 94 <property name="ignorePattern" value="^package.*|^import.*|a href|href|htt p://|https://|ftp://"/>
95 <property name="max" value="100"/> 95 <property name="max" value="100"/>
96 </module> 96 </module>
97 <module name="LeftCurly"> 97 <module name="LeftCurly">
98 <property name="severity" value="error"/> 98 <property name="severity" value="error"/>
99 </module> 99 </module>
100 <module name="RightCurly"> 100 <module name="RightCurly">
101 <property name="severity" value="error"/> 101 <property name="severity" value="error"/>
102 </module> 102 </module>
103 <module name="NeedBraces"> 103 <module name="NeedBraces">
104 <property name="severity" value="info"/> 104 <message key="needBraces" value="if, for, while, and do require curly brac es unless they are single-line statements."/>
105 <property name="tokens" value="LITERAL_FOR, LITERAL_WHILE, LITERAL_DO"/> 105 <property name="severity" value="error"/>
106 <property name="tokens" value="LITERAL_FOR, LITERAL_WHILE, LITERAL_DO, LIT ERAL_IF"/>
107 <property name="allowSingleLineStatement" value="true"/>
106 </module> 108 </module>
107 <module name="EmptyBlock"> 109 <module name="EmptyBlock">
108 <property name="severity" value="error"/> 110 <property name="severity" value="error"/>
109 <property name="option" value="text"/> 111 <property name="option" value="text"/>
110 <metadata name="altname" value="EmptyCatchBlock"/> 112 <metadata name="altname" value="EmptyCatchBlock"/>
111 </module> 113 </module>
112 <module name="UpperEll"> 114 <module name="UpperEll">
113 <property name="severity" value="error"/> 115 <property name="severity" value="error"/>
114 </module> 116 </module>
115 <module name="FallThrough"> 117 <module name="FallThrough">
(...skipping 87 matching lines...) Expand 10 before | Expand all | Expand 10 after
203 <module name="RegexpSingleline"> 205 <module name="RegexpSingleline">
204 <property name="severity" value="error"/> 206 <property name="severity" value="error"/>
205 <property name="format" value="[ \t]+$"/> 207 <property name="format" value="[ \t]+$"/>
206 <property name="message" value="Trailing whitespace"/> 208 <property name="message" value="Trailing whitespace"/>
207 </module> 209 </module>
208 <module name="RegexpHeader"> 210 <module name="RegexpHeader">
209 <property name="severity" value="error"/> 211 <property name="severity" value="error"/>
210 <property name="header" value="^// Copyright 20\d\d The Chromium Authors. Al l rights reserved.$\n^// Use of this source code is governed by a BSD-style lice nse that can be$\n^// found in the LICENSE file.$"/> 212 <property name="header" value="^// Copyright 20\d\d The Chromium Authors. Al l rights reserved.$\n^// Use of this source code is governed by a BSD-style lice nse that can be$\n^// found in the LICENSE file.$"/>
211 </module> 213 </module>
212 </module> 214 </module>
OLDNEW
« no previous file with comments | « content/public/test/android/javatests/src/org/chromium/content/browser/test/util/OrientationChangeObserverCriteria.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698