android_webview/java/src/org/chromium/android_webview/AwScrollOffsetManager.java - Issue 1054203002: Enable NeedsBraces check and fix some checkstyle issues.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/java/src/org/chromium/android_webview/AwScrollOffsetManager.java

Issue 1054203002: Enable NeedsBraces check and fix some checkstyle issues. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added if checks Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « android_webview/java/src/org/chromium/android_webview/AwContentsClient.java ('k') | android_webview/java/src/org/chromium/android_webview/JsResultHandler.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/java/src/org/chromium/android_webview/AwScrollOffsetManager.java

diff --git a/android_webview/java/src/org/chromium/android_webview/AwScrollOffsetManager.java b/android_webview/java/src/org/chromium/android_webview/AwScrollOffsetManager.java

index 11c166d5b00a3bf400d0a951db563b3a7e73b120..9ed9a14ff6f0d1ddf05cca819f81b9a858cee1eb 100644

--- a/android_webview/java/src/org/chromium/android_webview/AwScrollOffsetManager.java

+++ b/android_webview/java/src/org/chromium/android_webview/AwScrollOffsetManager.java

@@ -241,8 +241,7 @@ public class AwScrollOffsetManager {

return;

}

- if (x == mNativeScrollX && y == mNativeScrollY)

- return;

+ if (x == mNativeScrollX && y == mNativeScrollY) return;

// The scrollNativeTo call should be a simple store, so it's OK to assume it always

// succeeds.

@@ -322,8 +321,7 @@ public class AwScrollOffsetManager {

int dx = x - scrollX;

int dy = y - scrollY;

- if (dx == 0 && dy == 0)

- return false;

+ if (dx == 0 && dy == 0) return false;

mScroller.startScroll(scrollX, scrollY, dx, dy, computeDurationInMilliSec(dx, dy));

mDelegate.invalidate();