android_webview/javatests/src/org/chromium/android_webview/test/LoadUrlTest.java - Issue 1054203002: Enable NeedsBraces check and fix some checkstyle issues.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/javatests/src/org/chromium/android_webview/test/LoadUrlTest.java

Issue 1054203002: Enable NeedsBraces check and fix some checkstyle issues. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added if checks Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « android_webview/javatests/src/org/chromium/android_webview/test/HttpCacheTest.java ('k') | android_webview/javatests/src/org/chromium/android_webview/test/util/ImagePageGenerator.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/javatests/src/org/chromium/android_webview/test/LoadUrlTest.java

diff --git a/android_webview/javatests/src/org/chromium/android_webview/test/LoadUrlTest.java b/android_webview/javatests/src/org/chromium/android_webview/test/LoadUrlTest.java

index addbdbca0900120351ad5b49670dcd39e614d3cf..504a19fcf8ff303c7596c80a9c1845a5dd96f9ec 100644

--- a/android_webview/javatests/src/org/chromium/android_webview/test/LoadUrlTest.java

+++ b/android_webview/javatests/src/org/chromium/android_webview/test/LoadUrlTest.java

@@ -106,8 +106,9 @@ public class LoadUrlTest extends AwTestBase {

private static List<Pair<String, String>> createHeadersList(String[] namesAndValues) {

List<Pair<String, String>> result = new ArrayList<Pair<String, String>>();

- for (int i = 0; i < namesAndValues.length; i += 2)

+ for (int i = 0; i < namesAndValues.length; i += 2) {

result.add(Pair.create(namesAndValues[i], namesAndValues[i + 1]));

+ }

return result;

}