android_webview/java/src/org/chromium/android_webview/JsResultHandler.java - Issue 1054203002: Enable NeedsBraces check and fix some checkstyle issues.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/java/src/org/chromium/android_webview/JsResultHandler.java

Issue 1054203002: Enable NeedsBraces check and fix some checkstyle issues. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added if checks Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « android_webview/java/src/org/chromium/android_webview/AwScrollOffsetManager.java ('k') | android_webview/java/src/org/chromium/android_webview/ScrollAccessibilityHelper.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/java/src/org/chromium/android_webview/JsResultHandler.java

diff --git a/android_webview/java/src/org/chromium/android_webview/JsResultHandler.java b/android_webview/java/src/org/chromium/android_webview/JsResultHandler.java

index 2d00265767441a4414a4f28171d186a84a6fc991..53c065721556afad43d636ccee44eed7432135de 100644

--- a/android_webview/java/src/org/chromium/android_webview/JsResultHandler.java

+++ b/android_webview/java/src/org/chromium/android_webview/JsResultHandler.java

@@ -25,8 +25,7 @@ class JsResultHandler implements JsResultReceiver, JsPromptResultReceiver {

ThreadUtils.runOnUiThread(new Runnable() {

@Override

public void run() {

- if (mBridge != null)

- mBridge.confirmJsResult(mId, promptResult);

+ if (mBridge != null) mBridge.confirmJsResult(mId, promptResult);

mBridge = null;

}

});

@@ -37,8 +36,7 @@ class JsResultHandler implements JsResultReceiver, JsPromptResultReceiver {

ThreadUtils.runOnUiThread(new Runnable() {

@Override

public void run() {

- if (mBridge != null)

- mBridge.cancelJsResult(mId);

+ if (mBridge != null) mBridge.cancelJsResult(mId);

mBridge = null;

}

});