android_webview/java/src/org/chromium/android_webview/ScrollAccessibilityHelper.java - Issue 1054203002: Enable NeedsBraces check and fix some checkstyle issues.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/java/src/org/chromium/android_webview/ScrollAccessibilityHelper.java

Issue 1054203002: Enable NeedsBraces check and fix some checkstyle issues. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added if checks Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « android_webview/java/src/org/chromium/android_webview/JsResultHandler.java ('k') | android_webview/java/src/org/chromium/android_webview/permission/AwPermissionRequest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/java/src/org/chromium/android_webview/ScrollAccessibilityHelper.java

diff --git a/android_webview/java/src/org/chromium/android_webview/ScrollAccessibilityHelper.java b/android_webview/java/src/org/chromium/android_webview/ScrollAccessibilityHelper.java

index 836d73e54c755a90c29340a4887efee3aa9f6eb5..310781a409cfb308b27d5cde70f0e37bcc60cc8c 100644

--- a/android_webview/java/src/org/chromium/android_webview/ScrollAccessibilityHelper.java

+++ b/android_webview/java/src/org/chromium/android_webview/ScrollAccessibilityHelper.java

@@ -57,8 +57,7 @@ class ScrollAccessibilityHelper {

* {@link android.view.ViewConfiguration#getSendRecurringAccessibilityEventsInterval()}

public void postViewScrolledAccessibilityEventCallback() {

- if (mMsgViewScrolledQueued)

- return;

+ if (mMsgViewScrolledQueued) return;

mMsgViewScrolledQueued = true;

Message msg = mHandler.obtainMessage(HandlerCallback.MSG_VIEW_SCROLLED);

@@ -66,8 +65,7 @@ class ScrollAccessibilityHelper {

}

public void removePostedViewScrolledAccessibilityEventCallback() {

- if (!mMsgViewScrolledQueued)

- return;

+ if (!mMsgViewScrolledQueued) return;

mMsgViewScrolledQueued = false;

mHandler.removeMessages(HandlerCallback.MSG_VIEW_SCROLLED);