base/android/javatests/src/org/chromium/base/ObserverListTest.java - Issue 1054203002: Enable NeedsBraces check and fix some checkstyle issues.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/android/javatests/src/org/chromium/base/ObserverListTest.java

Issue 1054203002: Enable NeedsBraces check and fix some checkstyle issues. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added if checks Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « android_webview/unittestjava/src/org/chromium/android_webview/unittest/InputStreamUnittest.java ('k') | base/test/android/javatests/src/org/chromium/base/test/util/TestFileUtil.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: base/android/javatests/src/org/chromium/base/ObserverListTest.java

diff --git a/base/android/javatests/src/org/chromium/base/ObserverListTest.java b/base/android/javatests/src/org/chromium/base/ObserverListTest.java

index c28d51d72eea25e86add47b478d9477b1fc86401..973682b9328c0ff534bb58146387e395a4580311 100644

--- a/base/android/javatests/src/org/chromium/base/ObserverListTest.java

+++ b/base/android/javatests/src/org/chromium/base/ObserverListTest.java

@@ -72,8 +72,7 @@ public class ObserverListTest extends InstrumentationTestCase {

private static <T> int getSizeOfIterable(Iterable<T> iterable) {

int num = 0;

- for (T el : iterable)

- num++;

+ for (T el : iterable) num++;

return num;

}

@@ -91,8 +90,7 @@ public class ObserverListTest extends InstrumentationTestCase {

observerList.addObserver(a);

observerList.addObserver(b);

- for (Observer obs : observerList)

- obs.observe(10);

+ for (Observer obs : observerList) obs.observe(10);

// Removing an observer not in the list should do nothing.

observerList.removeObserver(e);

@@ -101,8 +99,7 @@ public class ObserverListTest extends InstrumentationTestCase {

observerList.addObserver(c);

observerList.addObserver(d);

- for (Observer obs : observerList)

- obs.observe(10);

+ for (Observer obs : observerList) obs.observe(10);

// observe should be called twice on a.

assertEquals(20, a.mTotal);

@@ -129,8 +126,7 @@ public class ObserverListTest extends InstrumentationTestCase {

observerList.addObserver(a);

observerList.addObserver(b);

- for (Observer obs : observerList)

- obs.observe(10);

+ for (Observer obs : observerList) obs.observe(10);

assertTrue(observerList.hasObserver(c));

assertEquals(10, a.mTotal);