Issue 9968078: Honor window size for chrome.windows.create when parent window is maximized.

Issue 9968078: Honor window size for chrome.windows.create when parent window is maximized. (Closed)

Created:
8 years, 8 months ago by Aaron Boodman

Modified:
8 years, 8 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews, asanka, Dmitry Lomov (no reviews), jennb, sadrul, nkostylev+watch_chromium.org, Aaron Boodman, Randy Smith (Not in Mondays), ben+watch_chromium.org, achuith+watch_chromium.org, mihaip+watch_chromium.org, dcheng, Dmitry Titov, feature-media-reviews_chromium.org, jianli, stevenjb+watch_chromium.org, Andrei, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Honor window size for chrome.windows.create when parent window is maximized. BUG=111618 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=130696

Patch Set 1 #

Patch Set 2 : Remove extraneous logging #

Total comments: 4

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+146 lines, -133 lines)			Patch
M	chrome/browser/chromeos/media/media_player.cc	View		1 chunk	+5 lines, -4 lines	0 comments	Download
M	chrome/browser/chromeos/tab_closeable_state_watcher_browsertest.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/debugger/devtools_window.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/extensions/extension_tabs_module.cc	View		2 chunks	+8 lines, -4 lines	0 comments	Download
M	chrome/browser/extensions/extension_tabs_test.cc	View		3 chunks	+6 lines, -6 lines	0 comments	Download
M	chrome/browser/printing/print_preview_tab_controller.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/sessions/session_restore_browsertest.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/ui/browser.h	View		2 chunks	+8 lines, -16 lines	0 comments	Download
M	chrome/browser/ui/browser.cc	View	1	6 chunks	+49 lines, -41 lines	2 comments	Download
M	chrome/browser/ui/browser_browsertest.cc	View		5 chunks	+12 lines, -10 lines	0 comments	Download
M	chrome/browser/ui/browser_init_browsertest.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/browser_navigator.cc	View		1 chunk	+4 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/browser_navigator_browsertest.cc	View		2 chunks	+9 lines, -5 lines	0 comments	Download
M	chrome/browser/ui/browser_tab_restore_service_delegate.cc	View		1 chunk	+3 lines, -5 lines	0 comments	Download
M	chrome/browser/ui/cocoa/applescript/browsercrapplication+applescript_test.mm	View		1 chunk	+5 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/cocoa/browser_window_controller_unittest.mm	View		1 chunk	+2 lines, -2 lines	2 comments	Download
M	chrome/browser/ui/panels/base_panel_browser_test.cc	View		1 chunk	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/ui/panels/panel_browser_window_cocoa_unittest.mm	View		1 chunk	+3 lines, -4 lines	0 comments	Download
M	chrome/browser/ui/panels/panel_browsertest.cc	View		2 chunks	+6 lines, -8 lines	0 comments	Download
M	chrome/browser/ui/views/ash/launcher/launcher_favicon_loader_browsertest.cc	View		1 chunk	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/ui/webui/chromeos/active_downloads_ui.cc	View		1 chunk	+3 lines, -2 lines	0 comments	Download
M	chrome/test/base/in_process_browser_test.cc	View		2 chunks	+5 lines, -6 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

Aaron Boodman

The only real changes are in browser.h, browser.cc, and extension_tabs_module.cc. This is a bit of ...

8 years, 8 months ago (2012-04-03 08:19:52 UTC) #1

Peter Kasting

I'm not sure I'm a good reviewer for this. Have you checked with Ben? He's ...

8 years, 8 months ago (2012-04-03 19:23:12 UTC) #2

Ben Goodger (Google)

Nice consolidation! LGTM https://chromiumcodereview.appspot.com/9968078/diff/1023/chrome/browser/ui/browser.cc File chrome/browser/ui/browser.cc (right): https://chromiumcodereview.appspot.com/9968078/diff/1023/chrome/browser/ui/browser.cc#newcode373 chrome/browser/ui/browser.cc:373: #if defined(OS_CHROMEOS) I think you can ...

8 years, 8 months ago (2012-04-04 16:14:41 UTC) #4

Aaron Boodman

http://codereview.chromium.org/9968078/diff/1023/chrome/browser/ui/browser.cc File chrome/browser/ui/browser.cc (right): http://codereview.chromium.org/9968078/diff/1023/chrome/browser/ui/browser.cc#newcode373 chrome/browser/ui/browser.cc:373: #if defined(OS_CHROMEOS) On 2012/04/04 16:14:42, Ben Goodger (Google) wrote: ...

8 years, 8 months ago (2012-04-04 18:46:58 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aa@chromium.org/9968078/1023

8 years, 8 months ago (2012-04-04 18:48:45 UTC) #6

commit-bot: I haz the power

8 years, 8 months ago (2012-04-04 18:48:57 UTC) #7

Presubmit check for 9968078-1023 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit Messages **
If this change requires manual test instructions to QA team, add
TEST=[instructions].

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    chrome/browser/printing
    chrome/browser/sessions

Presubmit checks took 2.4s to calculate.

Expand Messages | Collapse Messages