chrome/browser/printing/print_preview_tab_controller.cc - Issue 9968078: Honor window size for chrome.windows.create when parent window is maximized.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/printing/print_preview_tab_controller.cc

Issue 9968078: Honor window size for chrome.windows.create when parent window is maximized. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Remove extraneous logging Created 8 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/extension_tabs_test.cc ('k') | chrome/browser/sessions/session_restore_browsertest.cc » ('j') | chrome/browser/ui/browser.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/printing/print_preview_tab_controller.cc

diff --git a/chrome/browser/printing/print_preview_tab_controller.cc b/chrome/browser/printing/print_preview_tab_controller.cc

index e35f1bfa64354b34cea261e652bdb7c2a6178cf5..6dc23f6c0876fa33b864690a566524387edbfca7 100644

--- a/chrome/browser/printing/print_preview_tab_controller.cc

+++ b/chrome/browser/printing/print_preview_tab_controller.cc

@@ -414,7 +414,8 @@ TabContentsWrapper* PrintPreviewTabController::CreatePrintPreviewTab(

if (CommandLine::ForCurrentProcess()->HasSwitch(switches::kChromeFrame)) {

Profile* profile =

Profile::FromBrowserContext(web_contents->GetBrowserContext());

- current_browser = Browser::CreateForType(Browser::TYPE_POPUP, profile);

+ current_browser = Browser::CreateWithParams(

+ Browser::CreateParams(Browser::TYPE_POPUP, profile));

if (!current_browser) {

NOTREACHED() << "Failed to create popup browser window";

return NULL;

« no previous file with comments | « chrome/browser/extensions/extension_tabs_test.cc ('k') | chrome/browser/sessions/session_restore_browsertest.cc » ('j') | chrome/browser/ui/browser.cc » ('J')