chrome/browser/ui/browser_navigator.cc - Issue 9968078: Honor window size for chrome.windows.create when parent window is maximized.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/browser_navigator.cc

Issue 9968078: Honor window size for chrome.windows.create when parent window is maximized. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Remove extraneous logging Created 8 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/browser.cc ('K') | « chrome/browser/ui/browser_init_browsertest.cc ('k') | chrome/browser/ui/browser_navigator_browsertest.cc » ('j') | chrome/browser/ui/cocoa/browser_window_controller_unittest.mm » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/browser_navigator.cc

diff --git a/chrome/browser/ui/browser_navigator.cc b/chrome/browser/ui/browser_navigator.cc

index f749d5eb5c34d0041f0dbcc72d3a5c27c486b7a8..662de174fa9f7883c529127deb980c8fd762164b 100644

--- a/chrome/browser/ui/browser_navigator.cc

+++ b/chrome/browser/ui/browser_navigator.cc

@@ -161,8 +161,10 @@ Browser* GetBrowserForDisposition(browser::NavigateParams* params) {

browser_params.initial_bounds = params->window_bounds;

return Browser::CreateWithParams(browser_params);

} else {

- return Browser::CreateForApp(Browser::TYPE_POPUP, app_name,

- params->window_bounds, profile);

+ return Browser::CreateWithParams(

+ Browser::CreateParams::CreateForApp(

+ Browser::TYPE_POPUP, app_name, params->window_bounds,

+ profile));

}

return NULL;