Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2360)

Unified Diff: chrome/browser/ui/cocoa/browser_window_controller_unittest.mm

Issue 9968078: Honor window size for chrome.windows.create when parent window is maximized. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Remove extraneous logging Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/browser_window_controller_unittest.mm
diff --git a/chrome/browser/ui/cocoa/browser_window_controller_unittest.mm b/chrome/browser/ui/cocoa/browser_window_controller_unittest.mm
index d5e2aa0b80dbe6332470a6e94a4bad4fe6d0ebaa..86e3afe377cd5a394d329db854bcd1adb16acb5d 100644
--- a/chrome/browser/ui/cocoa/browser_window_controller_unittest.mm
+++ b/chrome/browser/ui/cocoa/browser_window_controller_unittest.mm
@@ -117,8 +117,8 @@ TEST_F(BrowserWindowControllerTest, TestNormal) {
// And make sure a controller for a pop-up window is not normal.
// popup_browser will be owned by its window.
- Browser *popup_browser(Browser::CreateForType(Browser::TYPE_POPUP,
- profile()));
+ Browser *popup_browser(Browser::CreateWithParams(
Ben Goodger (Google) 2012/04/04 16:14:42 Browser* popup_browser
Aaron Boodman 2012/04/04 18:46:58 Done.
+ Browser::CreateParams(Browser::TYPE_POPUP, profile())));
NSWindow *cocoaWindow = popup_browser->window()->GetNativeHandle();
BrowserWindowController* controller =
static_cast<BrowserWindowController*>([cocoaWindow windowController]);

Powered by Google App Engine
This is Rietveld 408576698