Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2241)

Unified Diff: chrome/browser/ui/browser_browsertest.cc

Issue 9968078: Honor window size for chrome.windows.create when parent window is maximized. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Remove extraneous logging Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/browser_browsertest.cc
diff --git a/chrome/browser/ui/browser_browsertest.cc b/chrome/browser/ui/browser_browsertest.cc
index 9715b49cbc6f0b7d84fe569c44105bfdb66f0034..85f130208ac11da6e9544e6af51bb5af1aded4f4 100644
--- a/chrome/browser/ui/browser_browsertest.cc
+++ b/chrome/browser/ui/browser_browsertest.cc
@@ -1308,8 +1308,8 @@ IN_PROC_BROWSER_TEST_F(BrowserTest,
// Create a popup (non-main-UI-type) browser. Settings command as well
// as Extensions should be disabled.
- Browser* popup_browser = browser()->CreateForType(Browser::TYPE_POPUP,
- browser()->profile());
+ Browser* popup_browser = browser()->CreateWithParams(
+ Browser::CreateParams(Browser::TYPE_POPUP, browser()->profile()));
CommandUpdater* popup_command_updater = popup_browser->command_updater();
EXPECT_FALSE(popup_command_updater->IsCommandEnabled(IDC_MANAGE_EXTENSIONS));
EXPECT_FALSE(popup_command_updater->IsCommandEnabled(IDC_OPTIONS));
@@ -1323,8 +1323,8 @@ IN_PROC_BROWSER_TEST_F(BrowserTest,
IN_PROC_BROWSER_TEST_F(BrowserTest,
DisableOptionsAndImportMenuItemsConsistently) {
// Create a popup browser.
- Browser* popup_browser = browser()->CreateForType(Browser::TYPE_POPUP,
- browser()->profile());
+ Browser* popup_browser = browser()->CreateWithParams(
+ Browser::CreateParams(Browser::TYPE_POPUP, browser()->profile()));
CommandUpdater* command_updater = popup_browser->command_updater();
// OPTIONS and IMPORT_SETTINGS are disabled for a non-normal UI.
EXPECT_FALSE(command_updater->IsCommandEnabled(IDC_OPTIONS));
@@ -1488,8 +1488,8 @@ IN_PROC_BROWSER_TEST_F(BrowserTest2, NoTabsInPopups) {
EXPECT_EQ(1, browser()->tab_count());
// Open a popup browser with a single blank foreground tab.
- Browser* popup_browser = browser()->CreateForType(Browser::TYPE_POPUP,
- browser()->profile());
+ Browser* popup_browser = browser()->CreateWithParams(
+ Browser::CreateParams(Browser::TYPE_POPUP, browser()->profile()));
popup_browser->AddBlankTab(true);
EXPECT_EQ(1, popup_browser->tab_count());
@@ -1505,8 +1505,9 @@ IN_PROC_BROWSER_TEST_F(BrowserTest2, NoTabsInPopups) {
EXPECT_EQ(2, browser()->tab_count());
// Open an app frame browser with a single blank foreground tab.
- Browser* app_browser =
- browser()->CreateForApp(L"Test", browser()->profile(), false);
+ Browser* app_browser = browser()->CreateWithParams(
+ Browser::CreateParams::CreateForApp(
+ L"Test", browser()->profile(), false));
app_browser->AddBlankTab(true);
EXPECT_EQ(1, app_browser->tab_count());
@@ -1523,8 +1524,9 @@ IN_PROC_BROWSER_TEST_F(BrowserTest2, NoTabsInPopups) {
EXPECT_EQ(3, browser()->tab_count());
// Open an app frame popup browser with a single blank foreground tab.
- Browser* app_popup_browser =
- browser()->CreateForApp(L"Test", browser()->profile(), false);
+ Browser* app_popup_browser = browser()->CreateWithParams(
+ Browser::CreateParams::CreateForApp(
+ L"Test", browser()->profile(), false));
app_popup_browser->AddBlankTab(true);
EXPECT_EQ(1, app_popup_browser->tab_count());

Powered by Google App Engine
This is Rietveld 408576698