chrome/browser/ui/panels/panel_browser_window_cocoa_unittest.mm - Issue 9968078: Honor window size for chrome.windows.create when parent window is maximized.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/panels/panel_browser_window_cocoa_unittest.mm

Issue 9968078: Honor window size for chrome.windows.create when parent window is maximized. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Remove extraneous logging Created 8 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/cocoa/browser_window_controller_unittest.mm ('K') | « chrome/browser/ui/panels/base_panel_browser_test.cc ('k') | chrome/browser/ui/panels/panel_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/panels/panel_browser_window_cocoa_unittest.mm

diff --git a/chrome/browser/ui/panels/panel_browser_window_cocoa_unittest.mm b/chrome/browser/ui/panels/panel_browser_window_cocoa_unittest.mm

index edd80c94534eb13c3676f0ee1d727c6fbeb76d9a..7836b8d930e8a0436c40c4b09259e919ebd47959 100644

--- a/chrome/browser/ui/panels/panel_browser_window_cocoa_unittest.mm

+++ b/chrome/browser/ui/panels/panel_browser_window_cocoa_unittest.mm

@@ -54,10 +54,9 @@ class PanelBrowserWindowCocoaTest : public CocoaProfileTest {

PanelManager* manager = PanelManager::GetInstance();

int panels_count = manager->num_panels();

- Browser* panel_browser = Browser::CreateForApp(Browser::TYPE_PANEL,

- panel_name,

- gfx::Rect(),

- profile());

+ Browser* panel_browser = Browser::CreateWithParams(

+ Browser::CreateParams::CreateForApp(

+ Browser::TYPE_PANEL, panel_name, gfx::Rect(), profile()));

EXPECT_EQ(panels_count + 1, manager->num_panels());

Panel* panel = static_cast<Panel*>(panel_browser->window());