Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2191)

Unified Diff: chrome/test/base/in_process_browser_test.cc

Issue 9968078: Honor window size for chrome.windows.create when parent window is maximized. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Remove extraneous logging Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/base/in_process_browser_test.cc
diff --git a/chrome/test/base/in_process_browser_test.cc b/chrome/test/base/in_process_browser_test.cc
index 75db28022c5968c5a8683e14c57d77898e328253..4ec9f221a44b926c13b7cac505cceef4eed8fde0 100644
--- a/chrome/test/base/in_process_browser_test.cc
+++ b/chrome/test/base/in_process_browser_test.cc
@@ -243,7 +243,8 @@ Browser* InProcessBrowserTest::CreateIncognitoBrowser() {
}
Browser* InProcessBrowserTest::CreateBrowserForPopup(Profile* profile) {
- Browser* browser = Browser::CreateForType(Browser::TYPE_POPUP, profile);
+ Browser* browser = Browser::CreateWithParams(
+ Browser::CreateParams(Browser::TYPE_POPUP, profile));
AddBlankTabAndShow(browser);
return browser;
}
@@ -251,11 +252,9 @@ Browser* InProcessBrowserTest::CreateBrowserForPopup(Profile* profile) {
Browser* InProcessBrowserTest::CreateBrowserForApp(
const std::string& app_name,
Profile* profile) {
- Browser* browser = Browser::CreateForApp(
- Browser::TYPE_POPUP,
- app_name,
- gfx::Rect(),
- profile);
+ Browser* browser = Browser::CreateWithParams(
+ Browser::CreateParams::CreateForApp(
+ Browser::TYPE_POPUP, app_name, gfx::Rect(), profile));
AddBlankTabAndShow(browser);
return browser;
}

Powered by Google App Engine
This is Rietveld 408576698