Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Issue 2982283002: Delete TelemetryInfo, MergedTelemetryInfo diagnostics. (Closed)

Created:
3 years, 5 months ago by benjhayden
Modified:
3 years, 4 months ago
Reviewers:
eakuefner
CC:
catapult-reviews_chromium.org, tracing-review_chromium.org
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

Patch Set 1 : #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : rebase #

Patch Set 5 : fix page_test_results_unittest.py #

Patch Set 6 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -1055 lines) Patch
M docs/histogram-set-json-format.md View 1 2 3 4 5 4 chunks +3 lines, -22 lines 0 comments Download
M docs/how-to-write-metrics.md View 1 2 3 4 5 3 chunks +10 lines, -21 lines 0 comments Download
D docs/images/how-to-write-metrics-telemetry.png View Binary file 0 comments Download
M docs/metrics-results-ui.md View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M telemetry/telemetry/internal/results/page_test_results_unittest.py View 1 2 3 4 4 chunks +6 lines, -6 lines 0 comments Download
M tracing/trace_viewer.gypi View 1 2 3 4 5 3 chunks +0 lines, -4 lines 0 comments Download
M tracing/tracing/value/diagnostics/all_diagnostics.html View 1 2 3 4 5 1 chunk +0 lines, -2 lines 0 comments Download
D tracing/tracing/value/diagnostics/merged_telemetry_info.html View 1 chunk +0 lines, -302 lines 0 comments Download
D tracing/tracing/value/diagnostics/merged_telemetry_info_test.html View 1 2 1 chunk +0 lines, -84 lines 0 comments Download
M tracing/tracing/value/diagnostics/reserved_infos.py View 1 2 3 4 5 1 chunk +0 lines, -5 lines 0 comments Download
M tracing/tracing/value/diagnostics/reserved_names.html View 1 2 3 4 5 1 chunk +0 lines, -5 lines 0 comments Download
D tracing/tracing/value/diagnostics/telemetry_info.html View 1 chunk +0 lines, -212 lines 0 comments Download
M tracing/tracing/value/histogram.py View 1 2 3 4 5 2 chunks +0 lines, -101 lines 0 comments Download
M tracing/tracing/value/histogram_parameter_collector.html View 1 2 3 2 chunks +0 lines, -28 lines 0 comments Download
M tracing/tracing/value/histogram_set_unittest.py View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/value/histogram_unittest.py View 1 2 3 4 5 1 chunk +0 lines, -74 lines 0 comments Download
M tracing/tracing/value/ui/collected_related_event_set_span_test.html View 1 2 3 1 chunk +0 lines, -8 lines 0 comments Download
M tracing/tracing/value/ui/diagnostic_span.html View 1 2 3 4 5 1 chunk +0 lines, -2 lines 0 comments Download
D tracing/tracing/value/ui/merged_telemetry_info_span.html View 1 chunk +0 lines, -104 lines 0 comments Download
D tracing/tracing/value/ui/telemetry_info_span.html View 1 chunk +0 lines, -73 lines 0 comments Download

Messages

Total messages: 23 (15 generated)
benjhayden
PTAL
3 years, 4 months ago (2017-08-20 05:38:23 UTC) #7
eakuefner
lgtm
3 years, 4 months ago (2017-08-23 16:55:10 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2982283002/160001
3 years, 4 months ago (2017-08-23 17:10:42 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: Catapult Linux Tryserver on master.tryserver.client.catapult (JOB_FAILED, https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20Linux%20Tryserver/builds/8969)
3 years, 4 months ago (2017-08-23 17:41:12 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2982283002/180001
3 years, 4 months ago (2017-08-23 17:49:20 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: Catapult Presubmit on master.tryserver.client.catapult (JOB_FAILED, https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20Presubmit/builds/8868)
3 years, 4 months ago (2017-08-23 18:00:13 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2982283002/200001
3 years, 4 months ago (2017-08-23 22:15:11 UTC) #20
commit-bot: I haz the power
3 years, 4 months ago (2017-08-23 22:41:29 UTC) #23
Message was sent while issue was closed.
Committed patchset #6 (id:200001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698