Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1491)

Unified Diff: docs/how-to-write-metrics.md

Issue 2982283002: Delete TelemetryInfo, MergedTelemetryInfo diagnostics. (Closed)
Patch Set: rebase Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « docs/histogram-set-json-format.md ('k') | docs/images/how-to-write-metrics-telemetry.png » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: docs/how-to-write-metrics.md
diff --git a/docs/how-to-write-metrics.md b/docs/how-to-write-metrics.md
index b5f8ed6cd17981a9520e06de8a8dd0436cb07648..84b6c66c3e59586d5ae66777ba2a446d8d02a702 100644
--- a/docs/how-to-write-metrics.md
+++ b/docs/how-to-write-metrics.md
@@ -169,17 +169,6 @@ histogram.addSample(number, {name: diagnostic})
![](/docs/images/how-to-write-metrics-related-histogram-breakdown.png)
-### Environment Information Diagnostics
-
- * [TelemetryInfo](/tracing/tracing/value/diagnostics/telemetry_info.html):
- This is automatically attached to every Histogram produced by telemetry.
- Structurally, it's a class with explicit named fields.
- Conceptually, it contains information about the origins of the trace that was
- consumed by the metric that produced the Histogram, such as the benchmark
- name, story name, benchmark start timestamp, etc.
- Visually, TelemetryInfos are displayed as a table.
-
- ![](/docs/images/how-to-write-metrics-telemetry.png)
### Other Diagnostics
@@ -289,18 +278,18 @@ default options are as follows:
metric would call `histogram.customizeSummaryOptions({percentile: [0.5]})`.
-## How histogram-set-table Uses Merging and TelemetryInfo
+## How histogram-set-table Uses Merging
-The histogram-set-table element uses the fields of TelemetryInfo, along with the
-merging capabilities of Histograms, to allow dynamic, hierarchical
-organization of histograms:
+The histogram-set-table element uses the predefined
+[HistogramGroupings](/tracing/tracing/value/histogram_set.html), along with the
+merging capabilities of Histograms, to allow dynamic, hierarchical organization
+of histograms:
-* TelemetryInfo has mostly string/number (story name, story/set repeat count,
- etc.) fields and one dict field that specifies the names of any story grouping
- keys together with their histogram.
+* Predefined HistogramGroupings specify how to find the benchmark, story, etc.
+ that produced the Histogram.
* After loading histograms, histogram-set-table computes categories to be
displayed by the groupby picker at the top of the UI:
- * Categories are fields of TelemetryInfo that have more than one value across
+ * Categories are HistogramGroupings that have more than one value across
all histograms in the HistogramSet.
* Instead of having one category for all story grouping keys, each grouping
individual grouping key may be listed as a category. For example, in Page
@@ -310,5 +299,5 @@ organization of histograms:
histograms from the bottom up. Expanding the rows of histogram-set-table, any
leaf nodes are histograms that were loaded, and their ancestors are computed by
merging.
-* histogram-set-table uses the "label" property of TelemetryInfo to define the
- columns of the table.
+* histogram-set-table uses the "label" HistogramGrouping to define the columns
+ of the table.
« no previous file with comments | « docs/histogram-set-json-format.md ('k') | docs/images/how-to-write-metrics-telemetry.png » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698