Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(348)

Unified Diff: tracing/tracing/value/histogram_parameter_collector.html

Issue 2982283002: Delete TelemetryInfo, MergedTelemetryInfo diagnostics. (Closed)
Patch Set: rebase Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tracing/tracing/value/histogram.py ('k') | tracing/tracing/value/histogram_set_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tracing/tracing/value/histogram_parameter_collector.html
diff --git a/tracing/tracing/value/histogram_parameter_collector.html b/tracing/tracing/value/histogram_parameter_collector.html
index 639c5b8ca55f15649c824e74fd3900234ca63e2b..2ecfe173edf963704cb2ab6d589dc09e20b02b66 100644
--- a/tracing/tracing/value/histogram_parameter_collector.html
+++ b/tracing/tracing/value/histogram_parameter_collector.html
@@ -70,12 +70,6 @@ tr.exportTo('tr.v', function() {
tr.v.d.RESERVED_NAMES.BENCHMARK_START);
if (startTime !== undefined) startTime = startTime.minDate.getTime();
- const telemetry = tr.v.d.TelemetryInfo.getFromHistogram(hist);
-
- if (startTime === undefined && telemetry && telemetry.benchmarkStart) {
- startTime = telemetry.benchmarkStart.getTime();
- }
-
const displayLabel = getDisplayLabel(hist);
if (this.labelsToStartTimes_.has(displayLabel)) {
@@ -104,28 +98,6 @@ tr.exportTo('tr.v', function() {
for (const tag of (storyTags || [])) {
allStoryTags.add(tag);
}
-
- if (!telemetry) continue;
-
- // Translate storyGroupingKeys like {cache_temp: 'cold'} into
- // HistogramGroupings like {
- // key: 'storyGroupingKey_cache_temp',
- // callback: (a function that takes a Histogram and returns its
- // TelemetryInfo.storyGroupingKeys.get('cache_temp')),
- // }
-
- for (const [key, value] of telemetry.storyGroupingKeys) {
- // If this storyGroupingKey is not yet known, then add a new
- // HistogramGrouping to keysToGroupings_ and a new Set of values to
- // keysToValues_
- const groupingKey = 'storyGroupingKey_' + key;
- if (this.keysToGroupings_.has(groupingKey)) continue;
- const callback = tr.v.d.TelemetryInfo.makeStoryGroupingKeyLabelGetter(
- key);
- this.keysToGroupings_.set(groupingKey, new tr.v.HistogramGrouping(
- groupingKey, callback));
- this.keysToValues_.set(groupingKey, new Set([callback(hist)]));
- }
}
tr.b.Timing.instant(
'HistogramParameterCollector', 'maxSampleCount', maxSampleCount);
« no previous file with comments | « tracing/tracing/value/histogram.py ('k') | tracing/tracing/value/histogram_set_unittest.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698