Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Side by Side Diff: telemetry/telemetry/internal/results/page_test_results_unittest.py

Issue 2982283002: Delete TelemetryInfo, MergedTelemetryInfo diagnostics. (Closed)
Patch Set: rebase Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « docs/metrics-results-ui.md ('k') | tracing/trace_viewer.gypi » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import os 5 import os
6 import unittest 6 import unittest
7 7
8 from telemetry import benchmark 8 from telemetry import benchmark
9 from telemetry import story 9 from telemetry import story
10 from telemetry.internal.results import base_test_results_unittest 10 from telemetry.internal.results import base_test_results_unittest
(...skipping 407 matching lines...) Expand 10 before | Expand all | Expand 10 after
418 '{\n \"enabled\": false,\n ' + 418 '{\n \"enabled\": false,\n ' +
419 '\"benchmark_name\": \"benchmark_name\"\n}\n') 419 '\"benchmark_name\": \"benchmark_name\"\n}\n')
420 420
421 def testAddSharedDiagnostic(self): 421 def testAddSharedDiagnostic(self):
422 results = page_test_results.PageTestResults() 422 results = page_test_results.PageTestResults()
423 results.telemetry_info.benchmark_start_epoch = 1501773200 423 results.telemetry_info.benchmark_start_epoch = 1501773200
424 results.WillRunPage(self.pages[0]) 424 results.WillRunPage(self.pages[0])
425 results.DidRunPage(self.pages[0]) 425 results.DidRunPage(self.pages[0])
426 results.CleanUp() 426 results.CleanUp()
427 results.histograms.AddSharedDiagnostic( 427 results.histograms.AddSharedDiagnostic(
428 reserved_infos.TELEMETRY.name, 428 reserved_infos.BENCHMARKS.name,
429 histogram_module.TelemetryInfo()) 429 histogram_module.GenericSet(['benchmark_name']))
430 430
431 benchmark_metadata = benchmark.BenchmarkMetadata( 431 benchmark_metadata = benchmark.BenchmarkMetadata(
432 'benchmark_name', 'benchmark_description') 432 'benchmark_name', 'benchmark_description')
433 results.PopulateHistogramSet(benchmark_metadata) 433 results.PopulateHistogramSet(benchmark_metadata)
434 434
435 histogram_dicts = results.AsHistogramDicts() 435 histogram_dicts = results.AsHistogramDicts()
436 self.assertEquals(1, len(histogram_dicts)) 436 self.assertEquals(1, len(histogram_dicts))
437 437
438 diag = diagnostic.Diagnostic.FromDict(histogram_dicts[0]) 438 diag = diagnostic.Diagnostic.FromDict(histogram_dicts[0])
439 self.assertIsInstance(diag, histogram_module.TelemetryInfo) 439 self.assertIsInstance(diag, histogram_module.GenericSet)
440 440
441 def testPopulateHistogramSet_UsesScalarValueData(self): 441 def testPopulateHistogramSet_UsesScalarValueData(self):
442 results = page_test_results.PageTestResults() 442 results = page_test_results.PageTestResults()
443 results.telemetry_info.benchmark_start_epoch = 1501773200 443 results.telemetry_info.benchmark_start_epoch = 1501773200
444 results.WillRunPage(self.pages[0]) 444 results.WillRunPage(self.pages[0])
445 results.AddValue(scalar.ScalarValue( 445 results.AddValue(scalar.ScalarValue(
446 self.pages[0], 'a', 'seconds', 3, 446 self.pages[0], 'a', 'seconds', 3,
447 improvement_direction=improvement_direction.UP)) 447 improvement_direction=improvement_direction.UP))
448 results.DidRunPage(self.pages[0]) 448 results.DidRunPage(self.pages[0])
449 results.CleanUp() 449 results.CleanUp()
450 450
451 benchmark_metadata = benchmark.BenchmarkMetadata( 451 benchmark_metadata = benchmark.BenchmarkMetadata(
452 'benchmark_name', 'benchmark_description') 452 'benchmark_name', 'benchmark_description')
453 results.PopulateHistogramSet(benchmark_metadata) 453 results.PopulateHistogramSet(benchmark_metadata)
454 454
455 histogram_dicts = results.AsHistogramDicts() 455 histogram_dicts = results.AsHistogramDicts()
456 self.assertEquals(1, len(histogram_dicts)) 456 self.assertEquals(1, len(histogram_dicts))
457 457
458 h = histogram_module.Histogram.FromDict(histogram_dicts[0]) 458 h = histogram_module.Histogram.FromDict(histogram_dicts[0])
459 self.assertEquals('a', h.name) 459 self.assertEquals('a', h.name)
460 460
461 def testPopulateHistogramSet_UsesHistogramSetData(self): 461 def testPopulateHistogramSet_UsesHistogramSetData(self):
462 original_diagnostic = histogram_module.TelemetryInfo() 462 original_diagnostic = histogram_module.GenericSet(['benchmark_name'])
463 463
464 results = page_test_results.PageTestResults() 464 results = page_test_results.PageTestResults()
465 results.telemetry_info.benchmark_start_epoch = 1501773200 465 results.telemetry_info.benchmark_start_epoch = 1501773200
466 results.WillRunPage(self.pages[0]) 466 results.WillRunPage(self.pages[0])
467 results.histograms.AddHistogram(histogram_module.Histogram('foo', 'count')) 467 results.histograms.AddHistogram(histogram_module.Histogram('foo', 'count'))
468 results.histograms.AddSharedDiagnostic( 468 results.histograms.AddSharedDiagnostic(
469 reserved_infos.TELEMETRY.name, original_diagnostic) 469 reserved_infos.BENCHMARKS.name, original_diagnostic)
470 results.DidRunPage(self.pages[0]) 470 results.DidRunPage(self.pages[0])
471 results.CleanUp() 471 results.CleanUp()
472 472
473 benchmark_metadata = benchmark.BenchmarkMetadata( 473 benchmark_metadata = benchmark.BenchmarkMetadata(
474 'benchmark_name', 'benchmark_description') 474 'benchmark_name', 'benchmark_description')
475 results.PopulateHistogramSet(benchmark_metadata) 475 results.PopulateHistogramSet(benchmark_metadata)
476 476
477 histogram_dicts = results.AsHistogramDicts() 477 histogram_dicts = results.AsHistogramDicts()
478 self.assertEquals(2, len(histogram_dicts)) 478 self.assertEquals(2, len(histogram_dicts))
479 479
480 hs = histogram_set.HistogramSet() 480 hs = histogram_set.HistogramSet()
481 hs.ImportDicts(histogram_dicts) 481 hs.ImportDicts(histogram_dicts)
482 482
483 diag = hs.LookupDiagnostic(original_diagnostic.guid) 483 diag = hs.LookupDiagnostic(original_diagnostic.guid)
484 self.assertIsInstance(diag, histogram_module.TelemetryInfo) 484 self.assertIsInstance(diag, histogram_module.GenericSet)
485 485
486 486
487 class PageTestResultsFilterTest(unittest.TestCase): 487 class PageTestResultsFilterTest(unittest.TestCase):
488 def setUp(self): 488 def setUp(self):
489 story_set = story.StorySet(base_dir=os.path.dirname(__file__)) 489 story_set = story.StorySet(base_dir=os.path.dirname(__file__))
490 story_set.AddStory( 490 story_set.AddStory(
491 page_module.Page('http://www.foo.com/', story_set, story_set.base_dir, 491 page_module.Page('http://www.foo.com/', story_set, story_set.base_dir,
492 name='http://www.foo.com')) 492 name='http://www.foo.com'))
493 story_set.AddStory( 493 story_set.AddStory(
494 page_module.Page('http://www.bar.com/', story_set, story_set.base_dir, 494 page_module.Page('http://www.bar.com/', story_set, story_set.base_dir,
(...skipping 112 matching lines...) Expand 10 before | Expand all | Expand 10 after
607 self.pages[0], 'b', 'seconds', 8, 607 self.pages[0], 'b', 'seconds', 8,
608 improvement_direction=improvement_direction.UP)) 608 improvement_direction=improvement_direction.UP))
609 results.AddValue(skip_value) 609 results.AddValue(skip_value)
610 results.DidRunPage(self.pages[0]) 610 results.DidRunPage(self.pages[0])
611 results.PrintSummary() 611 results.PrintSummary()
612 612
613 # Although predicate says only accept value with named 'a', skip value is 613 # Although predicate says only accept value with named 'a', skip value is
614 # added anyway. 614 # added anyway.
615 self.assertEquals(len(results.all_page_specific_values), 1) 615 self.assertEquals(len(results.all_page_specific_values), 1)
616 self.assertIn(skip_value, results.all_page_specific_values) 616 self.assertIn(skip_value, results.all_page_specific_values)
OLDNEW
« no previous file with comments | « docs/metrics-results-ui.md ('k') | tracing/trace_viewer.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698