Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Side by Side Diff: tracing/tracing/value/diagnostics/reserved_names.html

Issue 2982283002: Delete TelemetryInfo, MergedTelemetryInfo diagnostics. (Closed)
Patch Set: rebase Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 <!DOCTYPE html> 1 <!DOCTYPE html>
2 <!-- 2 <!--
3 Copyright 2017 The Chromium Authors. All rights reserved. 3 Copyright 2017 The Chromium Authors. All rights reserved.
4 Use of this source code is governed by a BSD-style license that can be 4 Use of this source code is governed by a BSD-style license that can be
5 found in the LICENSE file. 5 found in the LICENSE file.
6 --> 6 -->
7 7
8 <!-- 8 <!--
9 Include all Diagnostic subclasses here so that RESERVED_INFOS always has 9 Include all Diagnostic subclasses here so that RESERVED_INFOS always has
10 access to all subclasses. 10 access to all subclasses.
(...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after
44 SKIA_REVISIONS: {name: 'skiaRevisions', type: tr.v.d.GenericSet}, 44 SKIA_REVISIONS: {name: 'skiaRevisions', type: tr.v.d.GenericSet},
45 STORIES: {name: 'stories', type: tr.v.d.GenericSet}, 45 STORIES: {name: 'stories', type: tr.v.d.GenericSet},
46 STORYSET_REPEATS: {name: 'storysetRepeats', type: tr.v.d.GenericSet}, 46 STORYSET_REPEATS: {name: 'storysetRepeats', type: tr.v.d.GenericSet},
47 STORY_TAGS: {name: 'storyTags', type: tr.v.d.GenericSet}, 47 STORY_TAGS: {name: 'storyTags', type: tr.v.d.GenericSet},
48 TAG_MAP: {name: 'tagmap', type: tr.v.d.TagMap}, 48 TAG_MAP: {name: 'tagmap', type: tr.v.d.TagMap},
49 TRACE_START: {name: 'traceStart', type: tr.v.d.DateRange}, 49 TRACE_START: {name: 'traceStart', type: tr.v.d.DateRange},
50 TRACE_URLS: {name: 'traceUrls', type: tr.v.d.GenericSet}, 50 TRACE_URLS: {name: 'traceUrls', type: tr.v.d.GenericSet},
51 V8_COMMIT_POSITIONS: {name: 'v8CommitPositions', type: tr.v.d.DateRange}, 51 V8_COMMIT_POSITIONS: {name: 'v8CommitPositions', type: tr.v.d.DateRange},
52 V8_REVISIONS: {name: 'v8Revisions', type: tr.v.d.GenericSet}, 52 V8_REVISIONS: {name: 'v8Revisions', type: tr.v.d.GenericSet},
53 WEBRTC_REVISIONS: {name: 'webrtcRevisions', type: tr.v.d.GenericSet}, 53 WEBRTC_REVISIONS: {name: 'webrtcRevisions', type: tr.v.d.GenericSet},
54
55 // DEPRECATED https://github.com/catapult-project/catapult/issues/3507
56 INTERACTION_RECORD: {name: 'tir', type: tr.v.d.GenericSet},
57 ITERATION: {name: 'iteration'}, // Legacy name for TELEMETRY
58 TELEMETRY: {name: 'telemetry'}, // TelemetryInfo or MergedTelemetryInfo
59 }; 54 };
60 55
61 const RESERVED_NAMES = {}; 56 const RESERVED_NAMES = {};
62 57
63 const RESERVED_NAMES_TO_TYPES = new Map(); 58 const RESERVED_NAMES_TO_TYPES = new Map();
64 59
65 for (const [codename, info] of Object.entries(RESERVED_INFOS)) { 60 for (const [codename, info] of Object.entries(RESERVED_INFOS)) {
66 RESERVED_NAMES[codename] = info.name; 61 RESERVED_NAMES[codename] = info.name;
67 if (RESERVED_NAMES_TO_TYPES.has(info.name)) { 62 if (RESERVED_NAMES_TO_TYPES.has(info.name)) {
68 throw new Error(`Duplicate reserved name "${info.name}"`); 63 throw new Error(`Duplicate reserved name "${info.name}"`);
69 } 64 }
70 RESERVED_NAMES_TO_TYPES.set(info.name, info.type); 65 RESERVED_NAMES_TO_TYPES.set(info.name, info.type);
71 } 66 }
72 67
73 const RESERVED_NAMES_SET = new Set(Object.values(RESERVED_NAMES)); 68 const RESERVED_NAMES_SET = new Set(Object.values(RESERVED_NAMES));
74 69
75 return { 70 return {
76 RESERVED_INFOS, 71 RESERVED_INFOS,
77 RESERVED_NAMES, 72 RESERVED_NAMES,
78 RESERVED_NAMES_SET, 73 RESERVED_NAMES_SET,
79 RESERVED_NAMES_TO_TYPES, 74 RESERVED_NAMES_TO_TYPES,
80 }; 75 };
81 }); 76 });
82 </script> 77 </script>
OLDNEW
« no previous file with comments | « tracing/tracing/value/diagnostics/reserved_infos.py ('k') | tracing/tracing/value/diagnostics/telemetry_info.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698