Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(342)

Unified Diff: tracing/tracing/value/histogram.py

Issue 2982283002: Delete TelemetryInfo, MergedTelemetryInfo diagnostics. (Closed)
Patch Set: rebase Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tracing/tracing/value/histogram.py
diff --git a/tracing/tracing/value/histogram.py b/tracing/tracing/value/histogram.py
index 3d7e1cc27fa94bfa7572be312e744d48c5df8168..05e9a983c596fec2ee424418b51ca8f3a8fbdbdb 100644
--- a/tracing/tracing/value/histogram.py
+++ b/tracing/tracing/value/histogram.py
@@ -616,106 +616,6 @@ class TagMap(diagnostic.Diagnostic):
self.tags_to_story_names[name].add(t)
-# TODO(benjhayden): Unify this with telemetry's IterationInfo.
-class TelemetryInfo(diagnostic.Diagnostic):
-
- def __init__(self):
- super(TelemetryInfo, self).__init__()
- self._benchmark_name = ''
- self._benchmark_start = None
- self._label = ''
- self._legacy_tir_label = ''
- self._story_display_name = ''
- self._story_grouping_keys = {}
- self._story_url = ''
- self._storyset_repeat_counter = None
-
- def __eq__(self, other):
- if self.benchmark_name != other.benchmark_name:
- return False
- if self.benchmark_start != other.benchmark_start:
- return False
- if self.label != other.label:
- return False
- if self.legacy_tir_label != other.legacy_tir_label:
- return False
- if self.story_display_name != other.story_display_name:
- return False
- if self.story_grouping_keys != other.story_grouping_keys:
- return False
- if self.story_url != other.story_url:
- return False
- if self.storyset_repeat_counter != other.storyset_repeat_counter:
- return False
- return True
-
- def __ne__(self, other):
- return not self == other
-
- def AddInfo(self, info):
- if 'benchmarkName' in info:
- self._benchmark_name = info['benchmarkName']
- if 'benchmarkStartMs' in info:
- self._benchmark_start = info['benchmarkStartMs']
- if 'label' in info:
- self._label = info['label']
- if 'storyDisplayName' in info:
- self._story_display_name = info['storyDisplayName']
- if 'storyGroupingKeys' in info:
- self._story_grouping_keys = info['storyGroupingKeys']
- if 'storysetRepeatCounter' in info:
- self._storyset_repeat_counter = info['storysetRepeatCounter']
- if 'legacyTIRLabel' in info:
- self._legacy_tir_label = info['legacyTIRLabel']
-
- def _AsDictInto(self, d):
- d['benchmarkName'] = self.benchmark_name
- d['benchmarkStartMs'] = self.benchmark_start
- d['label'] = self.label
- d['storyDisplayName'] = self.story_display_name
- d['storyGroupingKeys'] = self.story_grouping_keys
- d['storysetRepeatCounter'] = self.storyset_repeat_counter
- d['legacyTIRLabel'] = self.legacy_tir_label
-
- @property
- def benchmark_name(self):
- return self._benchmark_name
-
- @property
- def benchmark_start(self):
- return self._benchmark_start
-
- @property
- def label(self):
- return self._label
-
- @property
- def story_display_name(self):
- return self._story_display_name
-
- @property
- def story_grouping_keys(self):
- return self._story_grouping_keys
-
- @property
- def storyset_repeat_counter(self):
- return self._storyset_repeat_counter
-
- @property
- def story_url(self):
- return self._story_url
-
- @property
- def legacy_tir_label(self):
- return self._legacy_tir_label
-
- @staticmethod
- def FromDict(d):
- info = TelemetryInfo()
- info.AddInfo(d)
- return info
-
-
class RelatedEventSet(diagnostic.Diagnostic):
def __init__(self):
@@ -1479,6 +1379,5 @@ all_diagnostics.DIAGNOSTICS_BY_NAME.update({
'DateRange': DateRange,
'TagMap': TagMap,
'RelatedHistogramBreakdown': RelatedHistogramBreakdown,
- 'TelemetryInfo': TelemetryInfo,
'RelatedHistogramMap': RelatedHistogramMap,
})
« no previous file with comments | « tracing/tracing/value/diagnostics/telemetry_info.html ('k') | tracing/tracing/value/histogram_parameter_collector.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698