Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(435)

Unified Diff: docs/histogram-set-json-format.md

Issue 2982283002: Delete TelemetryInfo, MergedTelemetryInfo diagnostics. (Closed)
Patch Set: rebase Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | docs/how-to-write-metrics.md » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: docs/histogram-set-json-format.md
diff --git a/docs/histogram-set-json-format.md b/docs/histogram-set-json-format.md
index 6558fb9ed2627962e417248cc4ff0ff86e017291..e6f13ef7a7dfcb5d400b66d24abce215ab2327ea 100644
--- a/docs/histogram-set-json-format.md
+++ b/docs/histogram-set-json-format.md
@@ -21,7 +21,7 @@ dictionary represents either a Histogram or a Diagnostic.
"shortName": "my metric",
"description": "this is my awesome amazing metric",
"diagnostics": {
- "telemetry": "923e4567-e89b-12d3-a456-426655440000",
+ "stories": "923e4567-e89b-12d3-a456-426655440000",
},
"sampleValues": [0, 1, 42, -999999999.99999, null],
"maxNumSampleValues": 1000,
@@ -50,13 +50,8 @@ dictionary represents either a Histogram or a Diagnostic.
},
{
"guid": "923e4567-e89b-12d3-a456-426655440000",
- "type": "TelemetryInfo",
- "benchmarkName": "memory",
- "benchmarkStartMs": 1234567890,
- "label": "abc",
- "storyDisplayName": "my story",
- "storyGroupingKeys": {"state": "pre"},
- "storysetRepeatCounter": 0,
+ "type": "GenericSet",
+ "values": ["browse:news:cnn"],
},
]
```
@@ -131,7 +126,6 @@ The only field that is required for all Diagnostics, `type`, must be one of
* `Breakdown`
* `RelatedHistogramMap`
* `RelatedHistogramBreakdown`
- * `TelemetryInfo`
* `Scalar`
If a Diagnostic is in the root array of the JSON, then it is shared, so it may be
@@ -143,19 +137,6 @@ field.
The other fields of Diagnostic dictionaries depend on `type`.
-### TelemetryInfo
-
-This tracks telemetry parameters when the Histogram was produced to allow users
-to compare or merge results across similar telemetry story runs.
-
- * `benchmarkName`: string
- * `benchmarkStartMs`: number of ms since unix epoch
- * `label`: string
- * `legacyTIRLabel`: string
- * `storyDisplayName`: string
- * `storyGroupingKeys`: dictionary mapping from strings to strings
- * `storysetRepeatCounter`: number
-
### GenericSet
This allows metrics to store arbitrary untyped data in Histograms.
« no previous file with comments | « no previous file | docs/how-to-write-metrics.md » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698