Issue 25044002: Tag handlers as HANDLER rather than STUB.

Issue 25044002: Tag handlers as HANDLER rather than STUB. (Closed)

Created:
7 years, 2 months ago by Toon Verwaest

Modified:
7 years, 2 months ago

Reviewers:
ulan

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Tag handlers as HANDLER rather than STUB. R=ulan@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=17012

Patch Set 2 : Addressed comment #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -20 lines)			Patch
M	src/arm/ic-arm.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/builtins.h	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/code-stubs.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/disassembler.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/ia32/ic-ia32.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/ic.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/log.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	src/log.cc	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	src/mips/ic-mips.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/objects.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	src/objects.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/objects-inl.h	View	1	2 chunks	+2 lines, -0 lines	0 comments	Download
M	src/stub-cache.cc	View		4 chunks	+4 lines, -4 lines	0 comments	Download
M	src/type-info.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/x64/ic-x64.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ulan

LGTM https://chromiumcodereview.appspot.com/25044002/diff/1/src/objects-inl.h File src/objects-inl.h (right): https://chromiumcodereview.appspot.com/25044002/diff/1/src/objects-inl.h#newcode3778 src/objects-inl.h:3778: ASSERT(kind() == STUB || Missing kind() == HANDLER ...

7 years, 2 months ago (2013-09-30 13:35:00 UTC) #2

Toon Verwaest

Addressed comment. https://chromiumcodereview.appspot.com/25044002/diff/1/src/objects-inl.h File src/objects-inl.h (right): https://chromiumcodereview.appspot.com/25044002/diff/1/src/objects-inl.h#newcode3778 src/objects-inl.h:3778: ASSERT(kind() == STUB || On 2013/09/30 13:35:00, ...

7 years, 2 months ago (2013-09-30 13:51:14 UTC) #3

Toon Verwaest

7 years, 2 months ago (2013-09-30 13:53:37 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r17012 (presubmit successful).

Expand Messages | Collapse Messages