Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Side by Side Diff: src/objects-inl.h

Issue 25044002: Tag handlers as HANDLER rather than STUB. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Addressed comment Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/objects.cc ('k') | src/stub-cache.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 3758 matching lines...) Expand 10 before | Expand all | Expand 10 after
3769 3769
3770 inline void Code::set_is_crankshafted(bool value) { 3770 inline void Code::set_is_crankshafted(bool value) {
3771 int previous = READ_UINT32_FIELD(this, kKindSpecificFlags2Offset); 3771 int previous = READ_UINT32_FIELD(this, kKindSpecificFlags2Offset);
3772 int updated = IsCrankshaftedField::update(previous, value); 3772 int updated = IsCrankshaftedField::update(previous, value);
3773 WRITE_UINT32_FIELD(this, kKindSpecificFlags2Offset, updated); 3773 WRITE_UINT32_FIELD(this, kKindSpecificFlags2Offset, updated);
3774 } 3774 }
3775 3775
3776 3776
3777 int Code::major_key() { 3777 int Code::major_key() {
3778 ASSERT(kind() == STUB || 3778 ASSERT(kind() == STUB ||
3779 kind() == HANDLER ||
3779 kind() == BINARY_OP_IC || 3780 kind() == BINARY_OP_IC ||
3780 kind() == COMPARE_IC || 3781 kind() == COMPARE_IC ||
3781 kind() == COMPARE_NIL_IC || 3782 kind() == COMPARE_NIL_IC ||
3782 kind() == STORE_IC || 3783 kind() == STORE_IC ||
3783 kind() == LOAD_IC || 3784 kind() == LOAD_IC ||
3784 kind() == KEYED_LOAD_IC || 3785 kind() == KEYED_LOAD_IC ||
3785 kind() == TO_BOOLEAN_IC); 3786 kind() == TO_BOOLEAN_IC);
3786 return StubMajorKeyField::decode( 3787 return StubMajorKeyField::decode(
3787 READ_UINT32_FIELD(this, kKindSpecificFlags2Offset)); 3788 READ_UINT32_FIELD(this, kKindSpecificFlags2Offset));
3788 } 3789 }
3789 3790
3790 3791
3791 void Code::set_major_key(int major) { 3792 void Code::set_major_key(int major) {
3792 ASSERT(kind() == STUB || 3793 ASSERT(kind() == STUB ||
3794 kind() == HANDLER ||
3793 kind() == BINARY_OP_IC || 3795 kind() == BINARY_OP_IC ||
3794 kind() == COMPARE_IC || 3796 kind() == COMPARE_IC ||
3795 kind() == COMPARE_NIL_IC || 3797 kind() == COMPARE_NIL_IC ||
3796 kind() == LOAD_IC || 3798 kind() == LOAD_IC ||
3797 kind() == KEYED_LOAD_IC || 3799 kind() == KEYED_LOAD_IC ||
3798 kind() == STORE_IC || 3800 kind() == STORE_IC ||
3799 kind() == KEYED_STORE_IC || 3801 kind() == KEYED_STORE_IC ||
3800 kind() == TO_BOOLEAN_IC); 3802 kind() == TO_BOOLEAN_IC);
3801 ASSERT(0 <= major && major < 256); 3803 ASSERT(0 <= major && major < 256);
3802 int previous = READ_UINT32_FIELD(this, kKindSpecificFlags2Offset); 3804 int previous = READ_UINT32_FIELD(this, kKindSpecificFlags2Offset);
(...skipping 2448 matching lines...) Expand 10 before | Expand all | Expand 10 after
6251 #undef WRITE_UINT32_FIELD 6253 #undef WRITE_UINT32_FIELD
6252 #undef READ_SHORT_FIELD 6254 #undef READ_SHORT_FIELD
6253 #undef WRITE_SHORT_FIELD 6255 #undef WRITE_SHORT_FIELD
6254 #undef READ_BYTE_FIELD 6256 #undef READ_BYTE_FIELD
6255 #undef WRITE_BYTE_FIELD 6257 #undef WRITE_BYTE_FIELD
6256 6258
6257 6259
6258 } } // namespace v8::internal 6260 } } // namespace v8::internal
6259 6261
6260 #endif // V8_OBJECTS_INL_H_ 6262 #endif // V8_OBJECTS_INL_H_
OLDNEW
« no previous file with comments | « src/objects.cc ('k') | src/stub-cache.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698