Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Side by Side Diff: src/objects.cc

Issue 25044002: Tag handlers as HANDLER rather than STUB. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Addressed comment Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/objects.h ('k') | src/objects-inl.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 10300 matching lines...) Expand 10 before | Expand all | Expand 10 after
10311 10311
10312 void Code::FindAllCode(CodeHandleList* code_list, int length) { 10312 void Code::FindAllCode(CodeHandleList* code_list, int length) {
10313 ASSERT(is_inline_cache_stub()); 10313 ASSERT(is_inline_cache_stub());
10314 DisallowHeapAllocation no_allocation; 10314 DisallowHeapAllocation no_allocation;
10315 int mask = RelocInfo::ModeMask(RelocInfo::CODE_TARGET); 10315 int mask = RelocInfo::ModeMask(RelocInfo::CODE_TARGET);
10316 int i = 0; 10316 int i = 0;
10317 for (RelocIterator it(this, mask); !it.done(); it.next()) { 10317 for (RelocIterator it(this, mask); !it.done(); it.next()) {
10318 if (i++ == length) return; 10318 if (i++ == length) return;
10319 RelocInfo* info = it.rinfo(); 10319 RelocInfo* info = it.rinfo();
10320 Code* code = Code::GetCodeFromTargetAddress(info->target_address()); 10320 Code* code = Code::GetCodeFromTargetAddress(info->target_address());
10321 ASSERT(code->kind() == Code::STUB); 10321 ASSERT(code->kind() == Code::HANDLER);
10322 code_list->Add(Handle<Code>(code)); 10322 code_list->Add(Handle<Code>(code));
10323 } 10323 }
10324 UNREACHABLE(); 10324 UNREACHABLE();
10325 } 10325 }
10326 10326
10327 10327
10328 Name* Code::FindFirstName() { 10328 Name* Code::FindFirstName() {
10329 ASSERT(is_inline_cache_stub()); 10329 ASSERT(is_inline_cache_stub());
10330 DisallowHeapAllocation no_allocation; 10330 DisallowHeapAllocation no_allocation;
10331 int mask = RelocInfo::ModeMask(RelocInfo::EMBEDDED_OBJECT); 10331 int mask = RelocInfo::ModeMask(RelocInfo::EMBEDDED_OBJECT);
(...skipping 5787 matching lines...) Expand 10 before | Expand all | Expand 10 after
16119 #define ERROR_MESSAGES_TEXTS(C, T) T, 16119 #define ERROR_MESSAGES_TEXTS(C, T) T,
16120 static const char* error_messages_[] = { 16120 static const char* error_messages_[] = {
16121 ERROR_MESSAGES_LIST(ERROR_MESSAGES_TEXTS) 16121 ERROR_MESSAGES_LIST(ERROR_MESSAGES_TEXTS)
16122 }; 16122 };
16123 #undef ERROR_MESSAGES_TEXTS 16123 #undef ERROR_MESSAGES_TEXTS
16124 return error_messages_[reason]; 16124 return error_messages_[reason];
16125 } 16125 }
16126 16126
16127 16127
16128 } } // namespace v8::internal 16128 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/objects.h ('k') | src/objects-inl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698