Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Side by Side Diff: src/code-stubs.h

Issue 25044002: Tag handlers as HANDLER rather than STUB. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Addressed comment Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/builtins.h ('k') | src/disassembler.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 886 matching lines...) Expand 10 before | Expand all | Expand 10 after
897 897
898 protected: 898 protected:
899 HICStub() { } 899 HICStub() { }
900 class KindBits: public BitField<Code::Kind, 0, 4> {}; 900 class KindBits: public BitField<Code::Kind, 0, 4> {};
901 virtual Code::Kind kind() const = 0; 901 virtual Code::Kind kind() const = 0;
902 }; 902 };
903 903
904 904
905 class HandlerStub: public HICStub { 905 class HandlerStub: public HICStub {
906 public: 906 public:
907 virtual Code::Kind GetCodeKind() const { return Code::STUB; } 907 virtual Code::Kind GetCodeKind() const { return Code::HANDLER; }
908 virtual int GetStubFlags() { return kind(); } 908 virtual int GetStubFlags() { return kind(); }
909 909
910 protected: 910 protected:
911 HandlerStub() : HICStub() { } 911 HandlerStub() : HICStub() { }
912 }; 912 };
913 913
914 914
915 class LoadFieldStub: public HandlerStub { 915 class LoadFieldStub: public HandlerStub {
916 public: 916 public:
917 LoadFieldStub(bool inobject, int index, Representation representation) 917 LoadFieldStub(bool inobject, int index, Representation representation)
(...skipping 1401 matching lines...) Expand 10 before | Expand all | Expand 10 after
2319 int MinorKey() { return 0; } 2319 int MinorKey() { return 0; }
2320 2320
2321 void Generate(MacroAssembler* masm); 2321 void Generate(MacroAssembler* masm);
2322 2322
2323 DISALLOW_COPY_AND_ASSIGN(ProfileEntryHookStub); 2323 DISALLOW_COPY_AND_ASSIGN(ProfileEntryHookStub);
2324 }; 2324 };
2325 2325
2326 } } // namespace v8::internal 2326 } } // namespace v8::internal
2327 2327
2328 #endif // V8_CODE_STUBS_H_ 2328 #endif // V8_CODE_STUBS_H_
OLDNEW
« no previous file with comments | « src/builtins.h ('k') | src/disassembler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698