Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(395)

Side by Side Diff: src/type-info.cc

Issue 25044002: Tag handlers as HANDLER rather than STUB. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Addressed comment Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/stub-cache.cc ('k') | src/x64/ic-x64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 233 matching lines...) Expand 10 before | Expand all | Expand 10 after
244 } 244 }
245 } 245 }
246 return STANDARD_STORE; 246 return STANDARD_STORE;
247 } 247 }
248 248
249 249
250 void TypeFeedbackOracle::LoadReceiverTypes(Property* expr, 250 void TypeFeedbackOracle::LoadReceiverTypes(Property* expr,
251 Handle<String> name, 251 Handle<String> name,
252 SmallMapList* types) { 252 SmallMapList* types) {
253 Code::Flags flags = Code::ComputeFlags( 253 Code::Flags flags = Code::ComputeFlags(
254 Code::STUB, MONOMORPHIC, Code::kNoExtraICState, 254 Code::HANDLER, MONOMORPHIC, Code::kNoExtraICState,
255 Code::NORMAL, Code::LOAD_IC); 255 Code::NORMAL, Code::LOAD_IC);
256 CollectReceiverTypes(expr->PropertyFeedbackId(), name, flags, types); 256 CollectReceiverTypes(expr->PropertyFeedbackId(), name, flags, types);
257 } 257 }
258 258
259 259
260 void TypeFeedbackOracle::StoreReceiverTypes(Assignment* expr, 260 void TypeFeedbackOracle::StoreReceiverTypes(Assignment* expr,
261 Handle<String> name, 261 Handle<String> name,
262 SmallMapList* types) { 262 SmallMapList* types) {
263 Code::Flags flags = Code::ComputeFlags( 263 Code::Flags flags = Code::ComputeFlags(
264 Code::STUB, MONOMORPHIC, Code::kNoExtraICState, 264 Code::HANDLER, MONOMORPHIC, Code::kNoExtraICState,
265 Code::NORMAL, Code::STORE_IC); 265 Code::NORMAL, Code::STORE_IC);
266 CollectReceiverTypes(expr->AssignmentFeedbackId(), name, flags, types); 266 CollectReceiverTypes(expr->AssignmentFeedbackId(), name, flags, types);
267 } 267 }
268 268
269 269
270 void TypeFeedbackOracle::CallReceiverTypes(Call* expr, 270 void TypeFeedbackOracle::CallReceiverTypes(Call* expr,
271 Handle<String> name, 271 Handle<String> name,
272 CallKind call_kind, 272 CallKind call_kind,
273 SmallMapList* types) { 273 SmallMapList* types) {
274 int arity = expr->arguments()->length(); 274 int arity = expr->arguments()->length();
(...skipping 417 matching lines...) Expand 10 before | Expand all | Expand 10 after
692 if (info.IsUninitialized()) return Representation::None(); 692 if (info.IsUninitialized()) return Representation::None();
693 if (info.IsSmi()) return Representation::Smi(); 693 if (info.IsSmi()) return Representation::Smi();
694 if (info.IsInteger32()) return Representation::Integer32(); 694 if (info.IsInteger32()) return Representation::Integer32();
695 if (info.IsDouble()) return Representation::Double(); 695 if (info.IsDouble()) return Representation::Double();
696 if (info.IsNumber()) return Representation::Double(); 696 if (info.IsNumber()) return Representation::Double();
697 return Representation::Tagged(); 697 return Representation::Tagged();
698 } 698 }
699 699
700 700
701 } } // namespace v8::internal 701 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/stub-cache.cc ('k') | src/x64/ic-x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698