Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Side by Side Diff: src/disassembler.cc

Issue 25044002: Tag handlers as HANDLER rather than STUB. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Addressed comment Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/code-stubs.h ('k') | src/ia32/ic-ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 232 matching lines...) Expand 10 before | Expand all | Expand 10 after
243 InlineCacheState ic_state = code->ic_state(); 243 InlineCacheState ic_state = code->ic_state();
244 out.AddFormatted(" %s, %s", Code::Kind2String(kind), 244 out.AddFormatted(" %s, %s", Code::Kind2String(kind),
245 Code::ICState2String(ic_state)); 245 Code::ICState2String(ic_state));
246 if (ic_state == MONOMORPHIC) { 246 if (ic_state == MONOMORPHIC) {
247 Code::StubType type = code->type(); 247 Code::StubType type = code->type();
248 out.AddFormatted(", %s", Code::StubType2String(type)); 248 out.AddFormatted(", %s", Code::StubType2String(type));
249 } 249 }
250 if (kind == Code::CALL_IC || kind == Code::KEYED_CALL_IC) { 250 if (kind == Code::CALL_IC || kind == Code::KEYED_CALL_IC) {
251 out.AddFormatted(", argc = %d", code->arguments_count()); 251 out.AddFormatted(", argc = %d", code->arguments_count());
252 } 252 }
253 } else if (kind == Code::STUB) { 253 } else if (kind == Code::STUB || kind == Code::HANDLER) {
254 // Reverse lookup required as the minor key cannot be retrieved 254 // Reverse lookup required as the minor key cannot be retrieved
255 // from the code object. 255 // from the code object.
256 Object* obj = heap->code_stubs()->SlowReverseLookup(code); 256 Object* obj = heap->code_stubs()->SlowReverseLookup(code);
257 if (obj != heap->undefined_value()) { 257 if (obj != heap->undefined_value()) {
258 ASSERT(obj->IsSmi()); 258 ASSERT(obj->IsSmi());
259 // Get the STUB key and extract major and minor key. 259 // Get the STUB key and extract major and minor key.
260 uint32_t key = Smi::cast(obj)->value(); 260 uint32_t key = Smi::cast(obj)->value();
261 uint32_t minor_key = CodeStub::MinorKeyFromKey(key); 261 uint32_t minor_key = CodeStub::MinorKeyFromKey(key);
262 CodeStub::Major major_key = CodeStub::GetMajorKey(code); 262 CodeStub::Major major_key = CodeStub::GetMajorKey(code);
263 ASSERT(major_key == CodeStub::MajorKeyFromKey(key)); 263 ASSERT(major_key == CodeStub::MajorKeyFromKey(key));
(...skipping 96 matching lines...) Expand 10 before | Expand all | Expand 10 after
360 int Disassembler::Decode(Isolate* isolate, FILE* f, byte* begin, byte* end) { 360 int Disassembler::Decode(Isolate* isolate, FILE* f, byte* begin, byte* end) {
361 return 0; 361 return 0;
362 } 362 }
363 363
364 364
365 void Disassembler::Decode(FILE* f, Code* code) {} 365 void Disassembler::Decode(FILE* f, Code* code) {}
366 366
367 #endif // ENABLE_DISASSEMBLER 367 #endif // ENABLE_DISASSEMBLER
368 368
369 } } // namespace v8::internal 369 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/code-stubs.h ('k') | src/ia32/ic-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698