Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: src/mips/ic-mips.cc

Issue 25044002: Tag handlers as HANDLER rather than STUB. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Addressed comment Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/log.cc ('k') | src/objects.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 638 matching lines...) Expand 10 before | Expand all | Expand 10 after
649 649
650 void LoadIC::GenerateMegamorphic(MacroAssembler* masm) { 650 void LoadIC::GenerateMegamorphic(MacroAssembler* masm) {
651 // ----------- S t a t e ------------- 651 // ----------- S t a t e -------------
652 // -- a2 : name 652 // -- a2 : name
653 // -- ra : return address 653 // -- ra : return address
654 // -- a0 : receiver 654 // -- a0 : receiver
655 // ----------------------------------- 655 // -----------------------------------
656 656
657 // Probe the stub cache. 657 // Probe the stub cache.
658 Code::Flags flags = Code::ComputeFlags( 658 Code::Flags flags = Code::ComputeFlags(
659 Code::STUB, MONOMORPHIC, Code::kNoExtraICState, 659 Code::HANDLER, MONOMORPHIC, Code::kNoExtraICState,
660 Code::NORMAL, Code::LOAD_IC); 660 Code::NORMAL, Code::LOAD_IC);
661 masm->isolate()->stub_cache()->GenerateProbe( 661 masm->isolate()->stub_cache()->GenerateProbe(
662 masm, flags, a0, a2, a3, t0, t1, t2); 662 masm, flags, a0, a2, a3, t0, t1, t2);
663 663
664 // Cache miss: Jump to runtime. 664 // Cache miss: Jump to runtime.
665 GenerateMiss(masm); 665 GenerateMiss(masm);
666 } 666 }
667 667
668 668
669 void LoadIC::GenerateNormal(MacroAssembler* masm) { 669 void LoadIC::GenerateNormal(MacroAssembler* masm) {
(...skipping 819 matching lines...) Expand 10 before | Expand all | Expand 10 after
1489 StrictModeFlag strict_mode) { 1489 StrictModeFlag strict_mode) {
1490 // ----------- S t a t e ------------- 1490 // ----------- S t a t e -------------
1491 // -- a0 : value 1491 // -- a0 : value
1492 // -- a1 : receiver 1492 // -- a1 : receiver
1493 // -- a2 : name 1493 // -- a2 : name
1494 // -- ra : return address 1494 // -- ra : return address
1495 // ----------------------------------- 1495 // -----------------------------------
1496 1496
1497 // Get the receiver from the stack and probe the stub cache. 1497 // Get the receiver from the stack and probe the stub cache.
1498 Code::Flags flags = Code::ComputeFlags( 1498 Code::Flags flags = Code::ComputeFlags(
1499 Code::STUB, MONOMORPHIC, strict_mode, 1499 Code::HANDLER, MONOMORPHIC, strict_mode,
1500 Code::NORMAL, Code::STORE_IC); 1500 Code::NORMAL, Code::STORE_IC);
1501 masm->isolate()->stub_cache()->GenerateProbe( 1501 masm->isolate()->stub_cache()->GenerateProbe(
1502 masm, flags, a1, a2, a3, t0, t1, t2); 1502 masm, flags, a1, a2, a3, t0, t1, t2);
1503 1503
1504 // Cache miss: Jump to runtime. 1504 // Cache miss: Jump to runtime.
1505 GenerateMiss(masm); 1505 GenerateMiss(masm);
1506 } 1506 }
1507 1507
1508 1508
1509 void StoreIC::GenerateMiss(MacroAssembler* masm) { 1509 void StoreIC::GenerateMiss(MacroAssembler* masm) {
(...skipping 149 matching lines...) Expand 10 before | Expand all | Expand 10 after
1659 } else { 1659 } else {
1660 ASSERT(Assembler::IsBne(branch_instr)); 1660 ASSERT(Assembler::IsBne(branch_instr));
1661 patcher.ChangeBranchCondition(eq); 1661 patcher.ChangeBranchCondition(eq);
1662 } 1662 }
1663 } 1663 }
1664 1664
1665 1665
1666 } } // namespace v8::internal 1666 } } // namespace v8::internal
1667 1667
1668 #endif // V8_TARGET_ARCH_MIPS 1668 #endif // V8_TARGET_ARCH_MIPS
OLDNEW
« no previous file with comments | « src/log.cc ('k') | src/objects.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698