Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Side by Side Diff: src/arm/ic-arm.cc

Issue 25044002: Tag handlers as HANDLER rather than STUB. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Addressed comment Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/builtins.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 638 matching lines...) Expand 10 before | Expand all | Expand 10 after
649 649
650 void LoadIC::GenerateMegamorphic(MacroAssembler* masm) { 650 void LoadIC::GenerateMegamorphic(MacroAssembler* masm) {
651 // ----------- S t a t e ------------- 651 // ----------- S t a t e -------------
652 // -- r2 : name 652 // -- r2 : name
653 // -- lr : return address 653 // -- lr : return address
654 // -- r0 : receiver 654 // -- r0 : receiver
655 // ----------------------------------- 655 // -----------------------------------
656 656
657 // Probe the stub cache. 657 // Probe the stub cache.
658 Code::Flags flags = Code::ComputeFlags( 658 Code::Flags flags = Code::ComputeFlags(
659 Code::STUB, MONOMORPHIC, Code::kNoExtraICState, 659 Code::HANDLER, MONOMORPHIC, Code::kNoExtraICState,
660 Code::NORMAL, Code::LOAD_IC); 660 Code::NORMAL, Code::LOAD_IC);
661 masm->isolate()->stub_cache()->GenerateProbe( 661 masm->isolate()->stub_cache()->GenerateProbe(
662 masm, flags, r0, r2, r3, r4, r5, r6); 662 masm, flags, r0, r2, r3, r4, r5, r6);
663 663
664 // Cache miss: Jump to runtime. 664 // Cache miss: Jump to runtime.
665 GenerateMiss(masm); 665 GenerateMiss(masm);
666 } 666 }
667 667
668 668
669 void LoadIC::GenerateNormal(MacroAssembler* masm) { 669 void LoadIC::GenerateNormal(MacroAssembler* masm) {
(...skipping 810 matching lines...) Expand 10 before | Expand all | Expand 10 after
1480 StrictModeFlag strict_mode) { 1480 StrictModeFlag strict_mode) {
1481 // ----------- S t a t e ------------- 1481 // ----------- S t a t e -------------
1482 // -- r0 : value 1482 // -- r0 : value
1483 // -- r1 : receiver 1483 // -- r1 : receiver
1484 // -- r2 : name 1484 // -- r2 : name
1485 // -- lr : return address 1485 // -- lr : return address
1486 // ----------------------------------- 1486 // -----------------------------------
1487 1487
1488 // Get the receiver from the stack and probe the stub cache. 1488 // Get the receiver from the stack and probe the stub cache.
1489 Code::Flags flags = Code::ComputeFlags( 1489 Code::Flags flags = Code::ComputeFlags(
1490 Code::STUB, MONOMORPHIC, strict_mode, 1490 Code::HANDLER, MONOMORPHIC, strict_mode,
1491 Code::NORMAL, Code::STORE_IC); 1491 Code::NORMAL, Code::STORE_IC);
1492 1492
1493 masm->isolate()->stub_cache()->GenerateProbe( 1493 masm->isolate()->stub_cache()->GenerateProbe(
1494 masm, flags, r1, r2, r3, r4, r5, r6); 1494 masm, flags, r1, r2, r3, r4, r5, r6);
1495 1495
1496 // Cache miss: Jump to runtime. 1496 // Cache miss: Jump to runtime.
1497 GenerateMiss(masm); 1497 GenerateMiss(masm);
1498 } 1498 }
1499 1499
1500 1500
(...skipping 152 matching lines...) Expand 10 before | Expand all | Expand 10 after
1653 } else { 1653 } else {
1654 ASSERT(Assembler::GetCondition(branch_instr) == ne); 1654 ASSERT(Assembler::GetCondition(branch_instr) == ne);
1655 patcher.EmitCondition(eq); 1655 patcher.EmitCondition(eq);
1656 } 1656 }
1657 } 1657 }
1658 1658
1659 1659
1660 } } // namespace v8::internal 1660 } } // namespace v8::internal
1661 1661
1662 #endif // V8_TARGET_ARCH_ARM 1662 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « no previous file | src/builtins.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698