Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(433)

Issue 19449002: Replace all instances of GrRect with SkRect. (Closed)

Created:
7 years, 5 months ago by tfarina
Modified:
7 years, 5 months ago
Reviewers:
robertphillips
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Replace all instances of GrRect with SkRect. And remove the typedef in GrRect.h. The same with GrIRect. R=robertphillips@google.com Committed: http://code.google.com/p/skia/source/detail?r=10130

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+188 lines, -228 lines) Patch
M gm/texdata.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M include/gpu/GrAARectRenderer.h View 4 chunks +9 lines, -9 lines 0 comments Download
M include/gpu/GrClipData.h View 3 chunks +2 lines, -5 lines 0 comments Download
M include/gpu/GrContext.h View 8 chunks +7 lines, -8 lines 0 comments Download
M include/gpu/GrFontScaler.h View 3 chunks +1 line, -4 lines 0 comments Download
M include/gpu/GrGlyph.h View 3 chunks +1 line, -4 lines 0 comments Download
M include/gpu/GrOvalRenderer.h View 2 chunks +4 lines, -5 lines 0 comments Download
M include/gpu/GrRect.h View 3 chunks +2 lines, -8 lines 0 comments Download
M include/gpu/GrRenderTarget.h View 4 chunks +5 lines, -5 lines 0 comments Download
M include/gpu/GrTextContext.h View 3 chunks +1 line, -4 lines 0 comments Download
M include/gpu/SkGr.h View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkMorphologyImageFilter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrAAHairLinePathRenderer.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M src/gpu/GrAARectRenderer.cpp View 6 chunks +8 lines, -8 lines 0 comments Download
M src/gpu/GrClipData.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M src/gpu/GrClipMaskCache.h View 4 chunks +4 lines, -4 lines 0 comments Download
M src/gpu/GrClipMaskManager.h View 2 chunks +3 lines, -4 lines 0 comments Download
M src/gpu/GrClipMaskManager.cpp View 3 chunks +5 lines, -5 lines 0 comments Download
M src/gpu/GrContext.cpp View 10 chunks +13 lines, -13 lines 0 comments Download
M src/gpu/GrDefaultPathRenderer.cpp View 2 chunks +1 line, -2 lines 0 comments Download
M src/gpu/GrDrawState.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/GrDrawTarget.h View 4 chunks +7 lines, -7 lines 0 comments Download
M src/gpu/GrDrawTarget.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M src/gpu/GrGpu.h View 8 chunks +5 lines, -10 lines 0 comments Download
M src/gpu/GrGpu.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrInOrderDrawBuffer.h View 3 chunks +4 lines, -4 lines 0 comments Download
M src/gpu/GrInOrderDrawBuffer.cpp View 4 chunks +6 lines, -6 lines 0 comments Download
M src/gpu/GrOvalRenderer.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M src/gpu/GrPath.h View 3 chunks +3 lines, -4 lines 0 comments Download
M src/gpu/GrPathUtils.h View 3 chunks +3 lines, -4 lines 0 comments Download
M src/gpu/GrPathUtils.cpp View 2 chunks +2 lines, -3 lines 0 comments Download
M src/gpu/GrRectanizer.h View 2 chunks +1 line, -4 lines 0 comments Download
M src/gpu/GrRenderTarget.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/GrSWMaskHelper.h View 3 chunks +4 lines, -4 lines 0 comments Download
M src/gpu/GrSWMaskHelper.cpp View 6 chunks +9 lines, -10 lines 0 comments Download
M src/gpu/GrSoftwarePathRenderer.cpp View 6 chunks +13 lines, -13 lines 0 comments Download
M src/gpu/GrStencilAndCoverPathRenderer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrTextContext.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrTextStrike.cpp View 3 chunks +1 line, -5 lines 0 comments Download
M src/gpu/SkGpuDevice.cpp View 5 chunks +8 lines, -8 lines 0 comments Download
M src/gpu/SkGrFontScaler.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/effects/GrConfigConversionEffect.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/gpu/effects/GrTextureDomainEffect.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/effects/GrTextureDomainEffect.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M src/gpu/gl/GrGpuGL.h View 4 chunks +3 lines, -6 lines 0 comments Download
M src/gpu/gl/GrGpuGL.cpp View 9 chunks +12 lines, -12 lines 0 comments Download
M src/gpu/gl/GrGpuGL_program.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/ClipCacheTest.cpp View 3 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
tfarina
7 years, 5 months ago (2013-07-16 23:35:56 UTC) #1
robertphillips
lgtm
7 years, 5 months ago (2013-07-17 00:08:31 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/tfarina@chromium.org/19449002/1
7 years, 5 months ago (2013-07-17 02:27:57 UTC) #3
commit-bot: I haz the power
7 years, 5 months ago (2013-07-17 21:39:52 UTC) #4
Message was sent while issue was closed.
Change committed as 10130

Powered by Google App Engine
This is Rietveld 408576698