Fix several findbugs issues

Fix several findbugs issues

This addresses the following classes of findbugs issues:
- ST, MS, SS, DLS, SIC

Also sprinkled in are eclipse auto-corrects of final, @Override and
import fixes.

NOTRY=true

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=188447

[joth, 2013-03-14 20:30:56]

lgtm

https://codereview.chromium.org/12545043/diff/1/content/public/android/javate...
File
content/public/android/javatests/src/org/chromium/content/browser/LongPressDetectorTest.java
(right):

https://codereview.chromium.org/12545043/diff/1/content/public/android/javate...
content/public/android/javatests/src/org/chromium/content/browser/LongPressDetectorTest.java:169:
final long eventTime = SystemClock.uptimeMillis();
micro-nit: to retain the exact behavior as before, I'd say "final long eventTime
= downTime"

[joth, 2013-03-14 20:31:12]

On 2013/03/14 20:30:56, joth wrote:
> lgtm
and Thanks!

> 
>
https://codereview.chromium.org/12545043/diff/1/content/public/android/javate...
> File
>
content/public/android/javatests/src/org/chromium/content/browser/LongPressDetectorTest.java
> (right):
> 
>
https://codereview.chromium.org/12545043/diff/1/content/public/android/javate...
>
content/public/android/javatests/src/org/chromium/content/browser/LongPressDetectorTest.java:169:
> final long eventTime = SystemClock.uptimeMillis();
> micro-nit: to retain the exact behavior as before, I'd say "final long
eventTime
> = downTime"

[Yaron, 2013-03-14 20:34:03]

https://codereview.chromium.org/12545043/diff/1/content/public/android/javate...
File
content/public/android/javatests/src/org/chromium/content/browser/LongPressDetectorTest.java
(right):

https://codereview.chromium.org/12545043/diff/1/content/public/android/javate...
content/public/android/javatests/src/org/chromium/content/browser/LongPressDetectorTest.java:169:
final long eventTime = SystemClock.uptimeMillis();
On 2013/03/14 20:30:56, joth wrote:
> micro-nit: to retain the exact behavior as before, I'd say "final long
eventTime
> = downTime"

Err, I assumed this was inadvertent but maybe I'm mistaken. At least it doesn't
match the other test cases. +Yusuf to comment

[joth, 2013-03-14 20:35:38]

https://codereview.chromium.org/12545043/diff/1/content/public/android/javate...
File
content/public/android/javatests/src/org/chromium/content/browser/LongPressDetectorTest.java
(right):

https://codereview.chromium.org/12545043/diff/1/content/public/android/javate...
content/public/android/javatests/src/org/chromium/content/browser/LongPressDetectorTest.java:169:
final long eventTime = SystemClock.uptimeMillis();
On 2013/03/14 20:34:04, Yaron wrote:
> On 2013/03/14 20:30:56, joth wrote:
> > micro-nit: to retain the exact behavior as before, I'd say "final long
> eventTime
> > = downTime"
> 
> Err, I assumed this was inadvertent but maybe I'm mistaken. At least it
doesn't
> match the other test cases. +Yusuf to comment

o i c. we do this all over the place in this file. agree, do it as you wrote it
then.

thanks

[Yusuf, 2013-03-15 18:08:36]

lgtm

[commit-bot: I haz the power, 2013-03-15 18:31:42]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yfriedman@chromium.org/12545043/1

[commit-bot: I haz the power, 2013-03-15 19:24:19]

Change committed as 188447