content/public/android/javatests/src/org/chromium/content/browser/PopupZoomerTest.java - Issue 12545043: Fix several findbugs issues

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/android/javatests/src/org/chromium/content/browser/PopupZoomerTest.java

Issue 12545043: Fix several findbugs issues (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/public/android/javatests/src/org/chromium/content/browser/LongPressDetectorTest.java ('K') | « content/public/android/javatests/src/org/chromium/content/browser/LongPressDetectorTest.java ('k') | content/public/test/android/javatests/src/org/chromium/content/browser/test/util/CallbackHelper.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/android/javatests/src/org/chromium/content/browser/PopupZoomerTest.java

diff --git a/content/public/android/javatests/src/org/chromium/content/browser/PopupZoomerTest.java b/content/public/android/javatests/src/org/chromium/content/browser/PopupZoomerTest.java

index c5d834d85606bf7336ed632afb48a5e798639470..29eeccdcb1d7555630056883b9b53c73815298e4 100644

--- a/content/public/android/javatests/src/org/chromium/content/browser/PopupZoomerTest.java

+++ b/content/public/android/javatests/src/org/chromium/content/browser/PopupZoomerTest.java

@@ -22,7 +22,7 @@ import org.chromium.base.test.util.Feature;

public class PopupZoomerTest extends InstrumentationTestCase {

private CustomCanvasPopupZoomer mPopupZoomer;

- private class CustomCanvasPopupZoomer extends PopupZoomer {

+ private static class CustomCanvasPopupZoomer extends PopupZoomer {

Canvas mCanvas;

long mPendingDraws = 0;

@@ -44,6 +44,7 @@ public class PopupZoomerTest extends InstrumentationTestCase {

// Test doesn't attach PopupZoomer to the view hierarchy,

// but onDraw() should still go on.

+ @Override

protected boolean acceptZeroSizeView() {

return true;

}