android_webview/javatests/src/org/chromium/android_webview/test/util/ImagePageGenerator.java - Issue 12545043: Fix several findbugs issues

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/javatests/src/org/chromium/android_webview/test/util/ImagePageGenerator.java

Issue 12545043: Fix several findbugs issues (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « android_webview/javatests/src/org/chromium/android_webview/test/TestContentProvider.java ('k') | build/android/findbugs_filter/findbugs_known_bugs.txt » ('j') | content/public/android/javatests/src/org/chromium/content/browser/LongPressDetectorTest.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/javatests/src/org/chromium/android_webview/test/util/ImagePageGenerator.java

diff --git a/android_webview/javatests/src/org/chromium/android_webview/test/util/ImagePageGenerator.java b/android_webview/javatests/src/org/chromium/android_webview/test/util/ImagePageGenerator.java

index 73ee1eef5b60a6a6847a85045beb09756873a923..504eb056b189efad4eb4d18452c99420d33a0619 100644

--- a/android_webview/javatests/src/org/chromium/android_webview/test/util/ImagePageGenerator.java

+++ b/android_webview/javatests/src/org/chromium/android_webview/test/util/ImagePageGenerator.java

@@ -13,7 +13,7 @@ public class ImagePageGenerator {

public static final String IMAGE_LOADED_STRING = "1";

public static final String IMAGE_NOT_LOADED_STRING = "0";

- private final String[] COLORS = {

+ private final static String[] COLORS = {

"AAAAIAAc3j0Ss", "AQABIAEayS9b0", "AgACIAIQ8BmAc", "AwADIAMW5wvJE",

"BAAEIAQZNWRTI", "BQAFIAUfInYaQ", "BgAGIAYVG0DB4", "BwAHIAcTDFKIg",

"CAAIIAgXCI+Rk", "CQAJIAkRH53Y8", "CgAKIAobJqsDU", "CwALIAsdMblKM",

@@ -21,13 +21,13 @@ public class ImagePageGenerator {

"D+AQAA/9vaUwc", "D/AQEBANNhzkw"

};

- private final String IMAGE_PREFIX = "iVBORw0KGgoAAAANSUhEUgAAAAEAAAABCAAAAAA" +

+ private final static String IMAGE_PREFIX = "iVBORw0KGgoAAAANSUhEUgAAAAEAAAABCAAAAAA" +

"6fptVAAAAAXNSR0IArs4c6QAAAA1JREFUCB0BAgD9/w";

- private final String IMAGE_SUFFIX = "AAAAASUVORK5CYII=";

+ private final static String IMAGE_SUFFIX = "AAAAASUVORK5CYII=";

private int mIndex;

- private boolean mAdvance;

+ private final boolean mAdvance;

public ImagePageGenerator(int startIndex, boolean advance) {

mIndex = startIndex;