Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1621)

Unified Diff: android_webview/javatests/src/org/chromium/android_webview/test/TestContentProvider.java

Issue 12545043: Fix several findbugs issues (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: android_webview/javatests/src/org/chromium/android_webview/test/TestContentProvider.java
diff --git a/android_webview/javatests/src/org/chromium/android_webview/test/TestContentProvider.java b/android_webview/javatests/src/org/chromium/android_webview/test/TestContentProvider.java
index b4581dd4d9240c80b9f3027f67a527eb040af7d3..87a08b70d91845d3ea1c565f08dc94ecee2ffa68 100644
--- a/android_webview/javatests/src/org/chromium/android_webview/test/TestContentProvider.java
+++ b/android_webview/javatests/src/org/chromium/android_webview/test/TestContentProvider.java
@@ -12,8 +12,8 @@ import android.content.ContentProvider;
import android.content.ContentValues;
import android.content.Context;
import android.content.res.AssetFileDescriptor;
-import android.database.Cursor;
import android.database.AbstractCursor;
+import android.database.Cursor;
import android.net.Uri;
import android.os.ParcelFileDescriptor;
import android.util.Log;
@@ -35,7 +35,7 @@ public class TestContentProvider extends ContentProvider {
private enum ColumnIndex {
RESOURCE_REQUEST_COUNT_COLUMN,
};
- private Map<String, Integer> mResourceRequestCount;
+ private final Map<String, Integer> mResourceRequestCount;
public static String createContentUrl(String target) {
return CONTENT_SCHEME + AUTHORITY + "/" + target;
@@ -107,8 +107,8 @@ public class TestContentProvider extends ContentProvider {
/**
* Cursor object for retrieving resource request counters.
*/
- private class ProviderStateCursor extends AbstractCursor {
- private int mResourceRequestCount;
+ private static class ProviderStateCursor extends AbstractCursor {
+ private final int mResourceRequestCount;
public ProviderStateCursor(int resourceRequestCount) {
mResourceRequestCount = resourceRequestCount;

Powered by Google App Engine
This is Rietveld 408576698