content/public/test/android/javatests/src/org/chromium/content/browser/test/util/HistoryUtils.java - Issue 12545043: Fix several findbugs issues

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/test/android/javatests/src/org/chromium/content/browser/test/util/HistoryUtils.java

Issue 12545043: Fix several findbugs issues (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/public/android/javatests/src/org/chromium/content/browser/LongPressDetectorTest.java ('K') | « content/public/test/android/javatests/src/org/chromium/content/browser/test/util/CallbackHelper.java ('k') | net/test/android/javatests/src/org/chromium/net/test/util/TestWebServer.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/test/android/javatests/src/org/chromium/content/browser/test/util/HistoryUtils.java

diff --git a/content/public/test/android/javatests/src/org/chromium/content/browser/test/util/HistoryUtils.java b/content/public/test/android/javatests/src/org/chromium/content/browser/test/util/HistoryUtils.java

index 59cd5084065cfb0fccdb9a41e70cda349a66bd17..db557e3915a925de104a3efc8e940ba4eb51af6a 100644

--- a/content/public/test/android/javatests/src/org/chromium/content/browser/test/util/HistoryUtils.java

+++ b/content/public/test/android/javatests/src/org/chromium/content/browser/test/util/HistoryUtils.java

@@ -7,6 +7,7 @@ package org.chromium.content.browser.test.util;

import android.app.Instrumentation;

import org.chromium.base.test.util.InstrumentationUtils;

+import org.chromium.content.browser.ContentView;

import org.chromium.content.browser.ContentViewCore;

import java.util.concurrent.Callable;

@@ -18,7 +19,7 @@ import java.util.concurrent.TimeUnit;

public class HistoryUtils {

- protected static int WAIT_TIMEOUT_SECONDS = 15;

+ protected final static int WAIT_TIMEOUT_SECONDS = 15;

/**

* Calls {@link ContentView#canGoBack()} on UI thread.