android_webview/javatests/src/org/chromium/android_webview/test/TestAwContentsClient.java - Issue 12545043: Fix several findbugs issues

Unified Diff: android_webview/javatests/src/org/chromium/android_webview/test/TestAwContentsClient.java

Issue 12545043: Fix several findbugs issues (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

« no previous file with comments | « android_webview/javatests/src/org/chromium/android_webview/test/LoadDataWithBaseUrlTest.java ('k') | android_webview/javatests/src/org/chromium/android_webview/test/TestContentProvider.java » ('j') | content/public/android/javatests/src/org/chromium/content/browser/LongPressDetectorTest.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/javatests/src/org/chromium/android_webview/test/TestAwContentsClient.java

diff --git a/android_webview/javatests/src/org/chromium/android_webview/test/TestAwContentsClient.java b/android_webview/javatests/src/org/chromium/android_webview/test/TestAwContentsClient.java

index 66b5f62520b7b62ea9f0a58cb53b7fec71afb5c3..12c1f14cb0f2e790340b3284de58418549934751 100644

--- a/android_webview/javatests/src/org/chromium/android_webview/test/TestAwContentsClient.java

+++ b/android_webview/javatests/src/org/chromium/android_webview/test/TestAwContentsClient.java

@@ -7,19 +7,19 @@ package org.chromium.android_webview.test;

import android.webkit.ConsoleMessage;

import org.chromium.content.browser.test.util.CallbackHelper;

-import org.chromium.content.browser.test.util.TestCallbackHelperContainer.OnPageStartedHelper;

+import org.chromium.content.browser.test.util.TestCallbackHelperContainer.OnEvaluateJavaScriptResultHelper;

import org.chromium.content.browser.test.util.TestCallbackHelperContainer.OnPageFinishedHelper;

+import org.chromium.content.browser.test.util.TestCallbackHelperContainer.OnPageStartedHelper;

import org.chromium.content.browser.test.util.TestCallbackHelperContainer.OnReceivedErrorHelper;

-import org.chromium.content.browser.test.util.TestCallbackHelperContainer.OnEvaluateJavaScriptResultHelper;

class TestAwContentsClient extends NullContentsClient {

private String mUpdatedTitle;

- private OnPageStartedHelper mOnPageStartedHelper;

- private OnPageFinishedHelper mOnPageFinishedHelper;

- private OnReceivedErrorHelper mOnReceivedErrorHelper;

- private OnEvaluateJavaScriptResultHelper mOnEvaluateJavaScriptResultHelper;

- private AddMessageToConsoleHelper mAddMessageToConsoleHelper;

- private OnScaleChangedHelper mOnScaleChangedHelper;

+ private final OnPageStartedHelper mOnPageStartedHelper;

+ private final OnPageFinishedHelper mOnPageFinishedHelper;

+ private final OnReceivedErrorHelper mOnReceivedErrorHelper;

+ private final OnEvaluateJavaScriptResultHelper mOnEvaluateJavaScriptResultHelper;

+ private final AddMessageToConsoleHelper mAddMessageToConsoleHelper;

+ private final OnScaleChangedHelper mOnScaleChangedHelper;

public TestAwContentsClient() {

mOnPageStartedHelper = new OnPageStartedHelper();

@@ -99,7 +99,7 @@ class TestAwContentsClient extends NullContentsClient {

return false;

}

- public class AddMessageToConsoleHelper extends CallbackHelper {

+ public static class AddMessageToConsoleHelper extends CallbackHelper {

private int mLevel;

private String mMessage;

private int mLineNumber;