android_webview/javatests/src/org/chromium/android_webview/test/LoadDataWithBaseUrlTest.java - Issue 12545043: Fix several findbugs issues

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/javatests/src/org/chromium/android_webview/test/LoadDataWithBaseUrlTest.java

Issue 12545043: Fix several findbugs issues (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « android_webview/javatests/src/org/chromium/android_webview/test/ClientOnPageFinishedTest.java ('k') | android_webview/javatests/src/org/chromium/android_webview/test/TestAwContentsClient.java » ('j') | content/public/android/javatests/src/org/chromium/content/browser/LongPressDetectorTest.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/javatests/src/org/chromium/android_webview/test/LoadDataWithBaseUrlTest.java

diff --git a/android_webview/javatests/src/org/chromium/android_webview/test/LoadDataWithBaseUrlTest.java b/android_webview/javatests/src/org/chromium/android_webview/test/LoadDataWithBaseUrlTest.java

index 5a06656f0440ed9ba8a9e95470d753a2f594e8bd..fd79a5ddab7451d951363bd5b7afda0ddb7227fd 100644

--- a/android_webview/javatests/src/org/chromium/android_webview/test/LoadDataWithBaseUrlTest.java

+++ b/android_webview/javatests/src/org/chromium/android_webview/test/LoadDataWithBaseUrlTest.java

@@ -12,12 +12,11 @@ import org.chromium.android_webview.AwContents;

import org.chromium.android_webview.test.util.CommonResources;

import org.chromium.base.test.util.DisabledTest;

import org.chromium.base.test.util.Feature;

-import org.chromium.base.test.util.UrlUtils;

-import org.chromium.content.browser.test.util.Criteria;

-import org.chromium.content.browser.test.util.CriteriaHelper;

import org.chromium.content.browser.ContentSettings;

import org.chromium.content.browser.ContentViewCore;

import org.chromium.content.browser.LoadUrlParams;

+import org.chromium.content.browser.test.util.Criteria;

+import org.chromium.content.browser.test.util.CriteriaHelper;

import org.chromium.content.browser.test.util.HistoryUtils;

import org.chromium.content.browser.test.util.TestCallbackHelperContainer;

import org.chromium.net.test.util.TestWebServer;

@@ -28,8 +27,6 @@ import java.util.concurrent.TimeUnit;

public class LoadDataWithBaseUrlTest extends AndroidWebViewTestBase {

- protected static int WAIT_TIMEOUT_SECONDS = 15;

private TestAwContentsClient mContentsClient;

private AwContents mAwContents;

private ContentViewCore mContentViewCore;