Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1450)

Unified Diff: content/public/android/javatests/src/org/chromium/content/browser/JavaBridgeArrayCoercionTest.java

Issue 12545043: Fix several findbugs issues (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/android/javatests/src/org/chromium/content/browser/JavaBridgeArrayCoercionTest.java
diff --git a/content/public/android/javatests/src/org/chromium/content/browser/JavaBridgeArrayCoercionTest.java b/content/public/android/javatests/src/org/chromium/content/browser/JavaBridgeArrayCoercionTest.java
index 81c77428d56d6b80475d7254d88ab2f5df87fd82..9c737f219fe7fc815e9176c64759ac71074d5fa9 100644
--- a/content/public/android/javatests/src/org/chromium/content/browser/JavaBridgeArrayCoercionTest.java
+++ b/content/public/android/javatests/src/org/chromium/content/browser/JavaBridgeArrayCoercionTest.java
@@ -6,8 +6,8 @@ package org.chromium.content.browser;
import android.test.suitebuilder.annotation.SmallTest;
-import org.chromium.base.test.util.Feature;
import org.chromium.base.test.util.DisabledTest;
+import org.chromium.base.test.util.Feature;
/**
* Part of the test suite for the Java Bridge. This class tests that we correctly convert
@@ -22,8 +22,8 @@ import org.chromium.base.test.util.DisabledTest;
*/
public class JavaBridgeArrayCoercionTest extends JavaBridgeTestBase {
private class TestObject extends Controller {
- private Object mObjectInstance;
- private CustomType mCustomTypeInstance;
+ private final Object mObjectInstance;
+ private final CustomType mCustomTypeInstance;
private boolean[] mBooleanArray;
private byte[] mByteArray;
@@ -141,7 +141,7 @@ public class JavaBridgeArrayCoercionTest extends JavaBridgeTestBase {
}
// Two custom types used when testing passing objects.
- private class CustomType {
+ private static class CustomType {
}
private TestObject mTestObject;

Powered by Google App Engine
This is Rietveld 408576698