Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(668)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 11753009: Simplify ExecuteJavaScript* functions. (Closed)

Created:
7 years, 11 months ago by darin (slow to review)
Modified:
7 years, 11 months ago
Reviewers:
jam
CC:
chromium-reviews, David Black, jam, tburkard+watch_chromium.org, dhollowa+watch_chromium.org, ahutter, browser-components-watch_chromium.org, gideonwald, dcheng, Dmitry Titov, apatrick_chromium, Albert Bodenhamer, markusheintz_, Ilya Sherman, kinuko+watch, joi+watch-content_chromium.org, melevin, vsevik, Aaron Boodman, benquan, kkania, dbeam+watch-autofill_chromium.org, dbeam+watch-options_chromium.org, dominich, darin-cc_chromium.org, tzik+watch_chromium.org, chromium-apps-reviews_chromium.org, pedrosimonetti+watch_chromium.org, dbeam+watch-ntp_chromium.org, Avi (use Gerrit), jennb, creis+watch_chromium.org, dyu1, cbentzel+watch_chromium.org, jianli, gavinp+prer_chromium.org, pam+watch_chromium.org, Raman Kakilate, Jered, samarth, sreeram, yurys, benjhayden+dwatch_chromium.org, dominich+watch_chromium.org, robertshield, Dane Wallinga, rdsmith+dwatch_chromium.org, ajwong+watch_chromium.org, estade+watch_chromium.org, mmenke, pfeldman
Visibility:
Public.

Description

Simplify ExecuteJavaScript* functions. Remove the "Java" and rename to ExecuteScript*. This better matches conventions elsewhere in the codebase. Introduce ExecuteScriptInFrame* variants for the less common case where script execution in a subframe is desired. Make it possible to pass the ExecuteScript* family of functions either a WebContents pointer or a RenderViewHost pointer to further simplify callsites. R=jam@chromium.org BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175156

Patch Set 1 #

Patch Set 2 : Fix Windows compile error. #

Patch Set 3 : Add PDF changes. #

Patch Set 4 : Update prerender_browsertest.cc. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+707 lines, -923 lines) Patch
M chrome/browser/autofill/autofill_browsertest.cc View 12 chunks +18 lines, -34 lines 0 comments Download
M chrome/browser/automation/automation_misc_browsertest.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/browser/automation/automation_tab_helper_browsertest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/browser_keyevents_browsertest.cc View 8 chunks +16 lines, -24 lines 0 comments Download
M chrome/browser/browsing_data/browsing_data_remover_browsertest.cc View 1 chunk +2 lines, -5 lines 0 comments Download
M chrome/browser/chrome_switches_browsertest.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/content_settings/content_settings_browsertest.cc View 2 chunks +4 lines, -7 lines 0 comments Download
M chrome/browser/devtools/devtools_sanity_browsertest.cc View 2 chunks +3 lines, -6 lines 0 comments Download
M chrome/browser/do_not_track_browsertest.cc View 2 chunks +4 lines, -6 lines 0 comments Download
M chrome/browser/download/download_browsertest.cc View 3 chunks +6 lines, -9 lines 0 comments Download
M chrome/browser/extensions/api/management/management_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/web_request/web_request_apitest.cc View 2 chunks +4 lines, -6 lines 0 comments Download
M chrome/browser/extensions/app_process_apitest.cc View 6 chunks +10 lines, -16 lines 0 comments Download
M chrome/browser/extensions/chrome_app_api_browsertest.cc View 8 chunks +25 lines, -24 lines 0 comments Download
M chrome/browser/extensions/content_script_apitest.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/extensions/docs/examples/apps/calculator_browsertest.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extension_bindings_apitest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_browsertest.cc View 2 chunks +4 lines, -7 lines 0 comments Download
M chrome/browser/extensions/extension_dom_clipboard_apitest.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extension_icon_source_apitest.cc View 4 chunks +8 lines, -12 lines 0 comments Download
M chrome/browser/extensions/extension_incognito_apitest.cc View 2 chunks +4 lines, -6 lines 0 comments Download
M chrome/browser/extensions/extension_keybinding_apitest.cc View 3 chunks +6 lines, -9 lines 0 comments Download
M chrome/browser/extensions/extension_nacl_browsertest.cc View 1 chunk +4 lines, -6 lines 0 comments Download
M chrome/browser/extensions/extension_resource_request_policy_apitest.cc View 12 chunks +24 lines, -36 lines 0 comments Download
M chrome/browser/extensions/extension_startup_browsertest.cc View 1 chunk +6 lines, -8 lines 0 comments Download
M chrome/browser/extensions/isolated_app_browsertest.cc View 7 chunks +45 lines, -59 lines 0 comments Download
M chrome/browser/extensions/lazy_background_page_apitest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/options_page_apitest.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M chrome/browser/extensions/plugin_apitest.cc View 7 chunks +14 lines, -14 lines 0 comments Download
M chrome/browser/extensions/subscribe_page_action_browsertest.cc View 1 chunk +4 lines, -6 lines 0 comments Download
M chrome/browser/extensions/web_contents_browsertest.cc View 2 chunks +4 lines, -6 lines 0 comments Download
M chrome/browser/extensions/web_view_browsertest.cc View 7 chunks +52 lines, -97 lines 0 comments Download
M chrome/browser/extensions/webstore_standalone_install_browsertest.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/extensions/window_open_apitest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/geolocation/geolocation_browsertest.cc View 4 chunks +8 lines, -11 lines 0 comments Download
M chrome/browser/history/history_browsertest.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M chrome/browser/instant/instant_browsertest.cc View 2 chunks +7 lines, -11 lines 0 comments Download
M chrome/browser/loadtimes_extension_bindings_browsertest.cc View 4 chunks +19 lines, -25 lines 0 comments Download
M chrome/browser/net/load_timing_observer_browsertest.cc View 1 chunk +5 lines, -8 lines 0 comments Download
M chrome/browser/notifications/notification_browsertest.cc View 4 chunks +8 lines, -12 lines 0 comments Download
M chrome/browser/policy/policy_browsertest.cc View 1 2 4 chunks +8 lines, -12 lines 0 comments Download
M chrome/browser/policy/policy_prefs_browsertest.cc View 2 chunks +4 lines, -5 lines 0 comments Download
M chrome/browser/popup_blocker_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/prerender/prerender_browsertest.cc View 1 2 3 10 chunks +24 lines, -32 lines 0 comments Download
M chrome/browser/ssl/ssl_browser_tests.cc View 13 chunks +26 lines, -37 lines 0 comments Download
M chrome/browser/tab_contents/view_source_browsertest.cc View 1 chunk +2 lines, -5 lines 0 comments Download
M chrome/browser/ui/browser_focus_uitest.cc View 6 chunks +10 lines, -16 lines 0 comments Download
M chrome/browser/ui/find_bar/find_bar_host_browsertest.cc View 4 chunks +8 lines, -12 lines 0 comments Download
M chrome/browser/ui/panels/panel_browsertest.cc View 3 chunks +6 lines, -11 lines 0 comments Download
M chrome/browser/ui/pdf/pdf_browsertest.cc View 1 2 4 chunks +14 lines, -21 lines 0 comments Download
M chrome/browser/ui/webui/bookmarks_ui_browsertest.cc View 1 chunk +4 lines, -6 lines 0 comments Download
M chrome/browser/ui/webui/inspect_ui_browsertest.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/ntp/new_tab_ui_browsertest.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/options/options_ui_browsertest.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/options/preferences_browsertest.cc View 6 chunks +14 lines, -16 lines 0 comments Download
M chrome/test/base/tracing_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/base/ui_test_utils.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/gpu/gpu_pixel_browsertest.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M content/browser/bookmarklet_browsertest.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M content/browser/database_browsertest.cc View 2 chunks +4 lines, -6 lines 0 comments Download
M content/browser/dom_storage/dom_storage_browsertest.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M content/browser/encrypted_media_browsertest.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M content/browser/fileapi/file_system_browsertest.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M content/browser/in_process_webkit/indexed_db_browsertest.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M content/browser/loader/resource_dispatcher_host_browsertest.cc View 5 chunks +7 lines, -14 lines 0 comments Download
M content/browser/renderer_host/render_view_host_manager_browsertest.cc View 1 2 33 chunks +70 lines, -105 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_win_browsertest.cc View 1 6 chunks +12 lines, -18 lines 0 comments Download
M content/browser/session_history_browsertest.cc View 3 chunks +8 lines, -12 lines 0 comments Download
M content/browser/site_per_process_browsertest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/webrtc_browsertest.cc View 1 chunk +1 line, -4 lines 0 comments Download
M content/public/test/browser_test_utils.h View 1 1 chunk +48 lines, -15 lines 0 comments Download
M content/public/test/browser_test_utils.cc View 1 2 3 chunks +73 lines, -33 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
darin (slow to review)
7 years, 11 months ago (2013-01-04 05:09:47 UTC) #1
jam
lgtm
7 years, 11 months ago (2013-01-04 06:53:54 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/darin@chromium.org/11753009/14003
7 years, 11 months ago (2013-01-04 09:27:57 UTC) #3
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) browser_tests
7 years, 11 months ago (2013-01-04 11:27:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/darin@chromium.org/11753009/14003
7 years, 11 months ago (2013-01-04 17:56:58 UTC) #5
commit-bot: I haz the power
7 years, 11 months ago (2013-01-04 18:30:45 UTC) #6
Message was sent while issue was closed. 
Change committed as 175156

Powered by Google App Engine
This is Rietveld 408576698