Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Side by Side Diff: chrome/browser/download/download_browsertest.cc

Issue 11753009: Simplify ExecuteJavaScript* functions. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Update prerender_browsertest.cc. Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <sstream> 5 #include <sstream>
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/bind_helpers.h" 8 #include "base/bind_helpers.h"
9 #include "base/file_path.h" 9 #include "base/file_path.h"
10 #include "base/file_util.h" 10 #include "base/file_util.h"
(...skipping 978 matching lines...) Expand 10 before | Expand all | Expand 10 after
989 DownloadRequestLimiter::DOWNLOADS_NOT_ALLOWED); 989 DownloadRequestLimiter::DOWNLOADS_NOT_ALLOWED);
990 990
991 // Try to start the download via Javascript and wait for the corresponding 991 // Try to start the download via Javascript and wait for the corresponding
992 // load stop event. 992 // load stop event.
993 content::TestNavigationObserver observer( 993 content::TestNavigationObserver observer(
994 content::Source<content::NavigationController>( 994 content::Source<content::NavigationController>(
995 &web_contents->GetController()), 995 &web_contents->GetController()),
996 NULL, 996 NULL,
997 1); 997 1);
998 bool download_assempted; 998 bool download_assempted;
999 ASSERT_TRUE(content::ExecuteJavaScriptAndExtractBool( 999 ASSERT_TRUE(content::ExecuteScriptAndExtractBool(
1000 chrome::GetActiveWebContents(browser())->GetRenderViewHost(), 1000 chrome::GetActiveWebContents(browser()),
1001 "",
1002 "window.domAutomationController.send(startDownload());", 1001 "window.domAutomationController.send(startDownload());",
1003 &download_assempted)); 1002 &download_assempted));
1004 ASSERT_TRUE(download_assempted); 1003 ASSERT_TRUE(download_assempted);
1005 observer.WaitForObservation( 1004 observer.WaitForObservation(
1006 base::Bind(&content::RunMessageLoop), 1005 base::Bind(&content::RunMessageLoop),
1007 base::Bind(&MessageLoop::Quit, 1006 base::Bind(&MessageLoop::Quit,
1008 base::Unretained(MessageLoopForUI::current()))); 1007 base::Unretained(MessageLoopForUI::current())));
1009 1008
1010 // Check that we did not download the file. 1009 // Check that we did not download the file.
1011 FilePath file(FILE_PATH_LITERAL("download-test1.lib")); 1010 FilePath file(FILE_PATH_LITERAL("download-test1.lib"));
(...skipping 406 matching lines...) Expand 10 before | Expand all | Expand 10 after
1418 GURL download_url(URLRequestMockHTTPJob::GetMockUrl(file)); 1417 GURL download_url(URLRequestMockHTTPJob::GetMockUrl(file));
1419 GURL flags_url(chrome::kChromeUIFlagsURL); 1418 GURL flags_url(chrome::kChromeUIFlagsURL);
1420 GURL extensions_url(chrome::kChromeUIExtensionsFrameURL); 1419 GURL extensions_url(chrome::kChromeUIExtensionsFrameURL);
1421 1420
1422 ui_test_utils::NavigateToURL(browser(), flags_url); 1421 ui_test_utils::NavigateToURL(browser(), flags_url);
1423 DownloadAndWait(browser(), download_url); 1422 DownloadAndWait(browser(), download_url);
1424 ui_test_utils::NavigateToURL(browser(), extensions_url); 1423 ui_test_utils::NavigateToURL(browser(), extensions_url);
1425 WebContents* contents = chrome::GetActiveWebContents(browser()); 1424 WebContents* contents = chrome::GetActiveWebContents(browser());
1426 ASSERT_TRUE(contents); 1425 ASSERT_TRUE(contents);
1427 bool webui_responded = false; 1426 bool webui_responded = false;
1428 EXPECT_TRUE(content::ExecuteJavaScriptAndExtractBool( 1427 EXPECT_TRUE(content::ExecuteScriptAndExtractBool(
1429 contents->GetRenderViewHost(), 1428 contents,
1430 "",
1431 "window.domAutomationController.send(window.webui_responded_);", 1429 "window.domAutomationController.send(window.webui_responded_);",
1432 &webui_responded)); 1430 &webui_responded));
1433 EXPECT_TRUE(webui_responded); 1431 EXPECT_TRUE(webui_responded);
1434 } 1432 }
1435 1433
1436 // Test for crbug.com/12745. This tests that if a download is initiated from 1434 // Test for crbug.com/12745. This tests that if a download is initiated from
1437 // a chrome:// page that has registered and onunload handler, the browser 1435 // a chrome:// page that has registered and onunload handler, the browser
1438 // will be able to close. 1436 // will be able to close.
1439 IN_PROC_BROWSER_TEST_F(DownloadTest, BrowserCloseAfterDownload) { 1437 IN_PROC_BROWSER_TEST_F(DownloadTest, BrowserCloseAfterDownload) {
1440 GURL downloads_url(chrome::kChromeUIFlagsURL); 1438 GURL downloads_url(chrome::kChromeUIFlagsURL);
1441 FilePath file(FILE_PATH_LITERAL("download-test1.lib")); 1439 FilePath file(FILE_PATH_LITERAL("download-test1.lib"));
1442 GURL download_url(URLRequestMockHTTPJob::GetMockUrl(file)); 1440 GURL download_url(URLRequestMockHTTPJob::GetMockUrl(file));
1443 1441
1444 ui_test_utils::NavigateToURL(browser(), downloads_url); 1442 ui_test_utils::NavigateToURL(browser(), downloads_url);
1445 WebContents* contents = chrome::GetActiveWebContents(browser()); 1443 WebContents* contents = chrome::GetActiveWebContents(browser());
1446 ASSERT_TRUE(contents); 1444 ASSERT_TRUE(contents);
1447 bool result = false; 1445 bool result = false;
1448 EXPECT_TRUE(content::ExecuteJavaScriptAndExtractBool( 1446 EXPECT_TRUE(content::ExecuteScriptAndExtractBool(
1449 contents->GetRenderViewHost(), 1447 contents,
1450 "",
1451 "window.onunload = function() { var do_nothing = 0; }; " 1448 "window.onunload = function() { var do_nothing = 0; }; "
1452 "window.domAutomationController.send(true);", 1449 "window.domAutomationController.send(true);",
1453 &result)); 1450 &result));
1454 EXPECT_TRUE(result); 1451 EXPECT_TRUE(result);
1455 1452
1456 DownloadAndWait(browser(), download_url); 1453 DownloadAndWait(browser(), download_url);
1457 1454
1458 content::WindowedNotificationObserver signal( 1455 content::WindowedNotificationObserver signal(
1459 chrome::NOTIFICATION_BROWSER_CLOSED, 1456 chrome::NOTIFICATION_BROWSER_CLOSED,
1460 content::Source<Browser>(browser())); 1457 content::Source<Browser>(browser()));
(...skipping 767 matching lines...) Expand 10 before | Expand all | Expand 10 after
2228 WebContents* web_contents = chrome::GetActiveWebContents(browser()); 2225 WebContents* web_contents = chrome::GetActiveWebContents(browser());
2229 scoped_ptr<DownloadUrlParameters> params( 2226 scoped_ptr<DownloadUrlParameters> params(
2230 DownloadUrlParameters::FromWebContents(web_contents, url)); 2227 DownloadUrlParameters::FromWebContents(web_contents, url));
2231 params->set_callback(base::Bind(&SetHiddenDownloadCallback)); 2228 params->set_callback(base::Bind(&SetHiddenDownloadCallback));
2232 download_manager->DownloadUrl(params.Pass()); 2229 download_manager->DownloadUrl(params.Pass());
2233 observer->WaitForFinished(); 2230 observer->WaitForFinished();
2234 2231
2235 // Verify that download shelf is not shown. 2232 // Verify that download shelf is not shown.
2236 EXPECT_FALSE(browser()->window()->IsDownloadShelfVisible()); 2233 EXPECT_FALSE(browser()->window()->IsDownloadShelfVisible());
2237 } 2234 }
OLDNEW
« no previous file with comments | « chrome/browser/do_not_track_browsertest.cc ('k') | chrome/browser/extensions/api/management/management_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698