chrome/browser/extensions/docs/examples/apps/calculator_browsertest.cc - Issue 11753009: Simplify ExecuteJavaScript* functions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/docs/examples/apps/calculator_browsertest.cc

Issue 11753009: Simplify ExecuteJavaScript* functions. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Update prerender_browsertest.cc. Created 7 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/content_script_apitest.cc ('k') | chrome/browser/extensions/extension_bindings_apitest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/docs/examples/apps/calculator_browsertest.cc

diff --git a/chrome/browser/extensions/docs/examples/apps/calculator_browsertest.cc b/chrome/browser/extensions/docs/examples/apps/calculator_browsertest.cc

index c451f232204588c457647559643e142659137acc..f87e3a04d754d60e7fa45fc23315691d1137aa3c 100644

--- a/chrome/browser/extensions/docs/examples/apps/calculator_browsertest.cc

+++ b/chrome/browser/extensions/docs/examples/apps/calculator_browsertest.cc

@@ -26,9 +26,8 @@ IN_PROC_BROWSER_TEST_F(CalculatorBrowserTest, Model) {

ui_test_utils::NavigateToURL(browser(), net::FilePathToFileURL(test_file));

bool success;

- bool executed = content::ExecuteJavaScriptAndExtractBool(

- chrome::GetActiveWebContents(browser())->GetRenderViewHost(),

- "",

+ bool executed = content::ExecuteScriptAndExtractBool(

+ chrome::GetActiveWebContents(browser()),

"window.domAutomationController.send(window.runTests().success)",

&success);

« no previous file with comments | « chrome/browser/extensions/content_script_apitest.cc ('k') | chrome/browser/extensions/extension_bindings_apitest.cc » ('j') | no next file with comments »