chrome/browser/ui/webui/ntp/new_tab_ui_browsertest.cc - Issue 11753009: Simplify ExecuteJavaScript* functions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/ntp/new_tab_ui_browsertest.cc

Issue 11753009: Simplify ExecuteJavaScript* functions. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Update prerender_browsertest.cc. Created 7 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/webui/ntp/new_tab_ui_browsertest.cc

diff --git a/chrome/browser/ui/webui/ntp/new_tab_ui_browsertest.cc b/chrome/browser/ui/webui/ntp/new_tab_ui_browsertest.cc

index d9af2ce8a344c516b72393cae6138f1661d4e03f..9039447b05d408881d087367d5c43d3c4f5f26d5 100644

--- a/chrome/browser/ui/webui/ntp/new_tab_ui_browsertest.cc

+++ b/chrome/browser/ui/webui/ntp/new_tab_ui_browsertest.cc

@@ -33,9 +33,8 @@ IN_PROC_BROWSER_TEST_F(NewTabUIBrowserTest, ChromeInternalLoadsNTP) {

// Ensure that we get there by checking for non-empty page content.

ui_test_utils::NavigateToURL(browser(), GURL("chrome-internal:"));

bool empty_inner_html = false;

- ASSERT_TRUE(content::ExecuteJavaScriptAndExtractBool(

- browser()->tab_strip_model()->GetWebContentsAt(0)->GetRenderViewHost(),

- "",

+ ASSERT_TRUE(content::ExecuteScriptAndExtractBool(

+ browser()->tab_strip_model()->GetWebContentsAt(0),

"window.domAutomationController.send(document.body.innerHTML == '')",

&empty_inner_html));

ASSERT_FALSE(empty_inner_html);