Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1333)

Unified Diff: chrome/browser/extensions/subscribe_page_action_browsertest.cc

Issue 11753009: Simplify ExecuteJavaScript* functions. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Update prerender_browsertest.cc. Created 7 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/plugin_apitest.cc ('k') | chrome/browser/extensions/web_contents_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/subscribe_page_action_browsertest.cc
diff --git a/chrome/browser/extensions/subscribe_page_action_browsertest.cc b/chrome/browser/extensions/subscribe_page_action_browsertest.cc
index a1f6204fcbfa90b89333400c672f6dc82ace8e62..2c21944e595d3c2b453469d79eb70bfc7d6672ad 100644
--- a/chrome/browser/extensions/subscribe_page_action_browsertest.cc
+++ b/chrome/browser/extensions/subscribe_page_action_browsertest.cc
@@ -77,17 +77,15 @@ GURL GetFeedUrl(net::TestServer* server, const std::string& feed_page,
}
bool ValidatePageElement(WebContents* tab,
- const std::string& frame,
+ const std::string& frame_xpath,
const std::string& javascript,
const std::string& expected_value) {
std::string returned_value;
std::string error;
- if (!content::ExecuteJavaScriptAndExtractString(
- tab->GetRenderViewHost(),
- frame,
- javascript,
- &returned_value))
+ if (!content::ExecuteScriptInFrameAndExtractString(tab, frame_xpath,
+ javascript,
+ &returned_value))
return false;
EXPECT_STREQ(expected_value.c_str(), returned_value.c_str());
« no previous file with comments | « chrome/browser/extensions/plugin_apitest.cc ('k') | chrome/browser/extensions/web_contents_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698