Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(511)

Unified Diff: chrome/browser/extensions/window_open_apitest.cc

Issue 11753009: Simplify ExecuteJavaScript* functions. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Update prerender_browsertest.cc. Created 7 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/window_open_apitest.cc
diff --git a/chrome/browser/extensions/window_open_apitest.cc b/chrome/browser/extensions/window_open_apitest.cc
index f2d77fbfe07ce6dcc59be1f40b46218037b8662a..1c8a406c9ac0eda1e07766a4562c52f81ece5e75 100644
--- a/chrome/browser/extensions/window_open_apitest.cc
+++ b/chrome/browser/extensions/window_open_apitest.cc
@@ -391,8 +391,8 @@ IN_PROC_BROWSER_TEST_F(ExtensionBrowserTest, WindowOpenExtension) {
start_url.Resolve("newtab.html"), true, &newtab));
bool result = false;
- ASSERT_TRUE(content::ExecuteJavaScriptAndExtractBool(
- newtab->GetRenderViewHost(), "", "testExtensionApi()", &result));
+ ASSERT_TRUE(content::ExecuteScriptAndExtractBool(newtab, "testExtensionApi()",
+ &result));
EXPECT_TRUE(result);
}
@@ -428,7 +428,7 @@ IN_PROC_BROWSER_TEST_F(ExtensionBrowserTest, WindowOpenNoPrivileges) {
// Extension API should succeed.
bool result = false;
- ASSERT_TRUE(content::ExecuteJavaScriptAndExtractBool(
- newtab->GetRenderViewHost(), "", "testExtensionApi()", &result));
+ ASSERT_TRUE(content::ExecuteScriptAndExtractBool(newtab, "testExtensionApi()",
+ &result));
EXPECT_TRUE(result);
}

Powered by Google App Engine
This is Rietveld 408576698