chrome/browser/extensions/options_page_apitest.cc - Issue 11753009: Simplify ExecuteJavaScript* functions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/options_page_apitest.cc

Issue 11753009: Simplify ExecuteJavaScript* functions. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Update prerender_browsertest.cc. Created 7 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/options_page_apitest.cc

diff --git a/chrome/browser/extensions/options_page_apitest.cc b/chrome/browser/extensions/options_page_apitest.cc

index a62f03c011c39f7985cd6c4b86bd1bc88ae817f1..7dd25c68676de2e372e3cb5ee058cb201ff335a4 100644

--- a/chrome/browser/extensions/options_page_apitest.cc

+++ b/chrome/browser/extensions/options_page_apitest.cc

@@ -40,10 +40,8 @@ IN_PROC_BROWSER_TEST_F(ExtensionBrowserTest, DISABLED_OptionsPage) {

// Go to the Extension Settings page and click the Options button.

ui_test_utils::NavigateToURL(browser(), GURL(chrome::kChromeUIExtensionsURL));

TabStripModel* tab_strip = browser()->tab_strip_model();

- ASSERT_TRUE(content::ExecuteJavaScript(

- tab_strip->GetActiveWebContents()->GetRenderViewHost(),

- "",

- kScriptClickOptionButton));

+ ASSERT_TRUE(content::ExecuteScript(tab_strip->GetActiveWebContents(),

+ kScriptClickOptionButton));

// If the options page hasn't already come up, wait for it.

if (tab_strip->count() == 1) {