chrome/browser/popup_blocker_browsertest.cc - Issue 11753009: Simplify ExecuteJavaScript* functions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/popup_blocker_browsertest.cc

Issue 11753009: Simplify ExecuteJavaScript* functions. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Update prerender_browsertest.cc. Created 7 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/popup_blocker_browsertest.cc

diff --git a/chrome/browser/popup_blocker_browsertest.cc b/chrome/browser/popup_blocker_browsertest.cc

index 8b931b50bd7819cf88035452c0ab9a9dc7f89cf9..7138a7f39d979099bf1480bf7b980432a8531909 100644

--- a/chrome/browser/popup_blocker_browsertest.cc

+++ b/chrome/browser/popup_blocker_browsertest.cc

@@ -54,7 +54,7 @@ class PopupBlockerBrowserTest : public InProcessBrowserTest {

// Do a round trip to the renderer first to flush any in-flight IPCs to

// create a to-be-blocked window.

WebContents* tab = chrome::GetActiveWebContents(browser);

- CHECK(content::ExecuteJavaScript(tab->GetRenderViewHost(), "", ""));

+ CHECK(content::ExecuteScript(tab, ""));

BlockedContentTabHelper* blocked_content_tab_helper =

BlockedContentTabHelper::FromWebContents(tab);

std::vector<WebContents*> blocked_contents;