Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(452)

Issue 11569019: Fix uses in ARM table media_instructions. (Closed)

Created:
8 years ago by Karl
Modified:
8 years ago
Reviewers:
JF
CC:
native-client-reviews_googlegroups.com
Visibility:
Public.

Description

Fix uses in ARM table media_instructions. BUG= http://code.google.com/p/nativeclient/issues/detail?id=3093 TEST= ./scons platform=arm run_arm32_decode_media_instructions_tests Committed: https://src.chromium.org/viewvc/native_client?view=rev&revision=10466

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Total comments: 12

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+600 lines, -401 lines) Patch
M src/trusted/validator_arm/actual_classes.h View 1 2 1 chunk +0 lines, -34 lines 0 comments Download
M src/trusted/validator_arm/actual_classes.cc View 1 2 1 chunk +0 lines, -15 lines 0 comments Download
M src/trusted/validator_arm/armv7.table View 1 2 1 chunk +68 lines, -40 lines 0 comments Download
M src/trusted/validator_arm/baseline_classes.h View 1 2 3 chunks +37 lines, -0 lines 0 comments Download
M src/trusted/validator_arm/baseline_classes.cc View 1 2 4 chunks +30 lines, -0 lines 0 comments Download
M src/trusted/validator_arm/gen/arm32_decode.h View 1 2 2 chunks +2 lines, -4 lines 0 comments Download
M src/trusted/validator_arm/gen/arm32_decode.cc View 1 2 5 chunks +6 lines, -8 lines 0 comments Download
M src/trusted/validator_arm/gen/arm32_decode_media_instructions_tests.cc View 1 2 21 chunks +379 lines, -137 lines 0 comments Download
M src/trusted/validator_arm/gen/arm32_decode_named.cc View 1 2 1 chunk +7 lines, -7 lines 0 comments Download
M src/trusted/validator_arm/gen/arm32_decode_named_classes.h View 1 2 16 chunks +42 lines, -122 lines 0 comments Download
M src/trusted/validator_arm/gen/arm32_decode_named_decoder.h View 1 2 8 chunks +7 lines, -12 lines 0 comments Download
M src/trusted/validator_arm/inst_classes_testers.h View 1 2 5 chunks +10 lines, -10 lines 0 comments Download
M src/trusted/validator_arm/inst_classes_testers.cc View 1 2 3 chunks +12 lines, -12 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Karl
8 years ago (2012-12-13 21:21:22 UTC) #1
Karl
https://chromiumcodereview.appspot.com/11569019/diff/1/src/trusted/validator_arm/armv7.table File src/trusted/validator_arm/armv7.table (right): https://chromiumcodereview.appspot.com/11569019/diff/1/src/trusted/validator_arm/armv7.table#newcode1331 src/trusted/validator_arm/armv7.table:1331: = *RdLsbWidth Fixed to use *RdRnLsbWidth.
8 years ago (2012-12-14 20:14:19 UTC) #2
JF
https://chromiumcodereview.appspot.com/11569019/diff/1018/src/trusted/validator_arm/armv7.table File src/trusted/validator_arm/armv7.table (right): https://chromiumcodereview.appspot.com/11569019/diff/1018/src/trusted/validator_arm/armv7.table#newcode1287 src/trusted/validator_arm/armv7.table:1287: uses := {Rn}; uses := {Rn, Rd}; https://chromiumcodereview.appspot.com/11569019/diff/1018/src/trusted/validator_arm/armv7.table#newcode1300 src/trusted/validator_arm/armv7.table:1300: ...
8 years ago (2012-12-14 22:39:33 UTC) #3
Karl
PTAL. Thanks. https://chromiumcodereview.appspot.com/11569019/diff/1018/src/trusted/validator_arm/armv7.table File src/trusted/validator_arm/armv7.table (right): https://chromiumcodereview.appspot.com/11569019/diff/1018/src/trusted/validator_arm/armv7.table#newcode1287 src/trusted/validator_arm/armv7.table:1287: uses := {Rn}; On 2012/12/14 22:39:33, JF ...
8 years ago (2012-12-17 17:35:57 UTC) #4
JF
8 years ago (2012-12-17 17:45:28 UTC) #5
lgtm

Powered by Google App Engine
This is Rietveld 408576698