Issue 10827145: Convert Aura to use ui::Event.

Issue 10827145: Convert Aura to use ui::Event. (Closed)

Created:
8 years, 4 months ago by Ben Goodger (Google)

Modified:
8 years, 4 months ago

Reviewers:
jam, sky

CC:
chromium-reviews, sadrul, dcheng, ben+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Convert Aura to use ui::Event. http://crbug.com/125937 TEST=existing Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=150587

Patch Set 1 : #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1314 lines, -2250 lines)			Patch
M	ash/accelerators/accelerator_controller.cc	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	ash/accelerators/accelerator_controller_unittest.cc	View	1 2 3	4 chunks	+7 lines, -7 lines	0 comments	Download
M	ash/accelerators/accelerator_dispatcher.cc	View	1 2 3	2 chunks	+2 lines, -2 lines	0 comments	Download
M	ash/accelerators/accelerator_filter.h	View	1 2 3	1 chunk	+6 lines, -5 lines	0 comments	Download
M	ash/accelerators/accelerator_filter.cc	View	1 2 3	3 chunks	+5 lines, -5 lines	0 comments	Download
M	ash/accelerators/accelerator_table.h	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	ash/accelerators/accelerator_table.cc	View	1 2 3	1 chunk	+0 lines, -1 line	0 comments	Download
M	ash/display/mouse_cursor_event_filter.h	View	1 2 3	1 chunk	+6 lines, -5 lines	0 comments	Download
M	ash/display/mouse_cursor_event_filter.cc	View	1 2 3	3 chunks	+6 lines, -6 lines	0 comments	Download
M	ash/display/screen_position_controller.cc	View	1 2 3	2 chunks	+2 lines, -2 lines	0 comments	Download
M	ash/drag_drop/drag_drop_controller.h	View	1 2 3	2 chunks	+8 lines, -8 lines	0 comments	Download
M	ash/drag_drop/drag_drop_controller.cc	View	1 2 3	9 chunks	+16 lines, -15 lines	0 comments	Download
M	ash/drag_drop/drag_drop_controller_unittest.cc	View	1 2 3	3 chunks	+5 lines, -5 lines	0 comments	Download
M	ash/event_rewriter_delegate.h	View	1 2 3	2 chunks	+3 lines, -3 lines	0 comments	Download
M	ash/extended_desktop_unittest.cc	View	1 2 3	3 chunks	+9 lines, -9 lines	0 comments	Download
M	ash/keyboard_overlay/keyboard_overlay_view.h	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	ash/keyboard_overlay/keyboard_overlay_view.cc	View	1 2 3	2 chunks	+2 lines, -1 line	0 comments	Download
M	ash/launcher/launcher_button.cc	View	1 2 3	1 chunk	+0 lines, -1 line	0 comments	Download
M	ash/launcher/launcher_tooltip_manager.h	View	1 2 3	1 chunk	+6 lines, -5 lines	0 comments	Download
M	ash/launcher/launcher_tooltip_manager.cc	View	1 2 3	4 chunks	+7 lines, -7 lines	0 comments	Download
M	ash/launcher/launcher_tooltip_manager_unittest.cc	View	1 2 3	4 chunks	+7 lines, -7 lines	0 comments	Download
M	ash/launcher/launcher_view_unittest.cc	View	1 2 3	2 chunks	+7 lines, -7 lines	0 comments	Download
M	ash/magnifier/magnification_controller.cc	View	1 2 3	4 chunks	+12 lines, -11 lines	0 comments	Download
M	ash/system/tray/tray_bubble_view.h	View	1 2 3	2 chunks	+6 lines, -6 lines	0 comments	Download
M	ash/system/tray/tray_bubble_view.cc	View	1 2 3	4 chunks	+6 lines, -6 lines	0 comments	Download
M	ash/test/test_activation_delegate.h	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	ash/test/test_activation_delegate.cc	View	1 2 3	2 chunks	+2 lines, -1 line	0 comments	Download
M	ash/tooltips/tooltip_controller.h	View	1 2 3	2 chunks	+6 lines, -8 lines	0 comments	Download
M	ash/tooltips/tooltip_controller.cc	View	1 2 3	5 chunks	+5 lines, -5 lines	0 comments	Download
M	ash/touch/touch_observer_hud.h	View	1 2 3	2 chunks	+6 lines, -7 lines	0 comments	Download
M	ash/touch/touch_observer_hud.cc	View	1 2 3	3 chunks	+5 lines, -5 lines	0 comments	Download
M	ash/touch/touch_uma.h	View	1 2 3	2 chunks	+2 lines, -4 lines	0 comments	Download
M	ash/touch/touch_uma.cc	View	1 2 3	8 chunks	+11 lines, -11 lines	0 comments	Download
M	ash/wm/activation_controller.h	View	1 2 3	3 chunks	+3 lines, -3 lines	0 comments	Download
M	ash/wm/activation_controller.cc	View	1 2 3	4 chunks	+4 lines, -4 lines	0 comments	Download
M	ash/wm/app_list_controller.h	View	1 2 3	2 chunks	+8 lines, -7 lines	0 comments	Download
M	ash/wm/app_list_controller.cc	View	1 2 3	4 chunks	+6 lines, -6 lines	0 comments	Download
M	ash/wm/coordinate_conversion.cc	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	ash/wm/event_rewriter_event_filter.h	View	1 2 3	1 chunk	+4 lines, -4 lines	0 comments	Download
M	ash/wm/event_rewriter_event_filter.cc	View	1 2 3	4 chunks	+5 lines, -5 lines	0 comments	Download
M	ash/wm/maximize_bubble_controller.cc	View	1 2 3	1 chunk	+0 lines, -1 line	0 comments	Download
M	ash/wm/overlay_event_filter.h	View	1 2 3	3 chunks	+5 lines, -6 lines	0 comments	Download
M	ash/wm/overlay_event_filter.cc	View	1 2 3	4 chunks	+5 lines, -4 lines	0 comments	Download
M	ash/wm/panel_layout_manager.cc	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	ash/wm/panel_window_event_filter.h	View	1 2 3	3 chunks	+11 lines, -8 lines	0 comments	Download
M	ash/wm/panel_window_event_filter.cc	View	1 2 3	3 chunks	+7 lines, -7 lines	0 comments	Download
M	ash/wm/partial_screenshot_view.h	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	ash/wm/partial_screenshot_view.cc	View	1 2 3	2 chunks	+2 lines, -1 line	0 comments	Download
M	ash/wm/shelf_layout_manager.cc	View	1 2 3	4 chunks	+11 lines, -10 lines	0 comments	Download
M	ash/wm/system_gesture_event_filter.h	View	1 2 3	4 chunks	+14 lines, -12 lines	0 comments	Download
M	ash/wm/system_gesture_event_filter.cc	View	1 2 3	8 chunks	+12 lines, -11 lines	0 comments	Download
M	ash/wm/system_gesture_event_filter_unittest.cc	View	1 2 3	19 chunks	+38 lines, -38 lines	0 comments	Download
M	ash/wm/system_modal_container_event_filter.h	View	1 2 3	1 chunk	+4 lines, -4 lines	0 comments	Download
M	ash/wm/system_modal_container_event_filter.cc	View	1 2 3	2 chunks	+5 lines, -5 lines	0 comments	Download
M	ash/wm/system_modal_container_layout_manager.cc	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	ash/wm/toplevel_window_event_filter.h	View	1 2 3	3 chunks	+13 lines, -10 lines	0 comments	Download
M	ash/wm/toplevel_window_event_filter.cc	View	1 2 3	9 chunks	+10 lines, -10 lines	0 comments	Download
M	ash/wm/toplevel_window_event_filter_unittest.cc	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	ash/wm/user_activity_detector.h	View	1 2 3	1 chunk	+4 lines, -4 lines	0 comments	Download
M	ash/wm/user_activity_detector.cc	View	1 2 3	5 chunks	+5 lines, -5 lines	0 comments	Download
M	ash/wm/user_activity_detector_unittest.cc	View	1 2 3	5 chunks	+7 lines, -7 lines	0 comments	Download
M	ash/wm/window_cycle_controller.cc	View	1 2 3	4 chunks	+11 lines, -10 lines	0 comments	Download
M	ash/wm/window_manager_unittest.cc	View	1 2 3	11 chunks	+31 lines, -31 lines	0 comments	Download
M	ash/wm/window_modality_controller.h	View	1 2 3	3 chunks	+8 lines, -7 lines	0 comments	Download
M	ash/wm/window_modality_controller.cc	View	1 2 3	3 chunks	+6 lines, -6 lines	0 comments	Download
M	ash/wm/window_modality_controller_unittest.cc	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	ash/wm/workspace/frame_maximize_button.cc	View	1 2 3	4 chunks	+11 lines, -11 lines	0 comments	Download
M	ash/wm/workspace/multi_window_resize_controller.cc	View	1 2 3	3 chunks	+3 lines, -3 lines	0 comments	Download
M	ash/wm/workspace/workspace_event_filter.h	View	1 2 3	3 chunks	+2 lines, -3 lines	0 comments	Download
M	ash/wm/workspace/workspace_event_filter.cc	View	1 2 3	3 chunks	+3 lines, -3 lines	0 comments	Download
M	ash/wm/workspace/workspace_layout_manager.h	View	1 2 3	1 chunk	+0 lines, -1 line	0 comments	Download
M	ash/wm/workspace/workspace_layout_manager.cc	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	ash/wm/workspace/workspace_window_resizer.cc	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/ash/event_rewriter.h	View	1 2 3	4 chunks	+9 lines, -9 lines	0 comments	Download
M	chrome/browser/ui/ash/event_rewriter.cc	View	1 2 3	8 chunks	+10 lines, -10 lines	0 comments	Download
M	chrome/browser/ui/ash/event_rewriter_unittest.cc	View	1 2 3	3 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/views/ash/launcher/browser_launcher_item_controller_unittest.cc	View	1 2 3	2 chunks	+2 lines, -1 line	0 comments	Download
M	chrome/browser/ui/views/toolbar_view.cc	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	content/browser/renderer_host/native_web_keyboard_event_aura.cc	View	1 2 3	3 chunks	+4 lines, -4 lines	0 comments	Download
M	content/browser/renderer_host/render_widget_host_view_aura.h	View	1 2 3	2 chunks	+6 lines, -5 lines	0 comments	Download
M	content/browser/renderer_host/render_widget_host_view_aura.cc	View	1 2 3	8 chunks	+10 lines, -10 lines	0 comments	Download
M	content/browser/renderer_host/web_input_event_aura.h	View	1 2 3	1 chunk	+10 lines, -10 lines	0 comments	Download
M	content/browser/renderer_host/web_input_event_aura.cc	View	1 2 3	8 chunks	+22 lines, -22 lines	0 comments	Download
M	content/browser/renderer_host/web_input_event_aura_unittest.cc	View	1 2 3	5 chunks	+5 lines, -5 lines	0 comments	Download
M	content/browser/renderer_host/web_input_event_aurax11.cc	View	1 2 3	11 chunks	+11 lines, -11 lines	0 comments	Download
M	content/browser/web_contents/web_contents_view_aura.h	View	1 2 3	3 chunks	+12 lines, -7 lines	0 comments	Download
M	content/browser/web_contents/web_contents_view_aura.cc	View	1 2 3	9 chunks	+10 lines, -10 lines	0 comments	Download
M	content/renderer/render_view_browsertest.cc	View	1 2 3	7 chunks	+7 lines, -7 lines	0 comments	Download
M	ui/aura/aura.gyp	View	1 2 3	2 chunks	+0 lines, -5 lines	0 comments	Download
M	ui/aura/bench/bench_main.cc	View	1 2 3	1 chunk	+0 lines, -1 line	0 comments	Download
M	ui/aura/client/activation_client.h	View	1 2 3	2 chunks	+6 lines, -3 lines	0 comments	Download
M	ui/aura/client/activation_delegate.h	View	1 2 3	2 chunks	+5 lines, -2 lines	0 comments	Download
M	ui/aura/client/drag_drop_client.h	View	1 2 3	2 chunks	+10 lines, -3 lines	0 comments	Download
M	ui/aura/client/drag_drop_delegate.h	View	1 2 3	3 chunks	+7 lines, -4 lines	0 comments	Download
M	ui/aura/client/tooltip_client.h	View	1 2 3	1 chunk	+0 lines, -1 line	0 comments	Download
M	ui/aura/demo/demo_main.cc	View	1 2 3	3 chunks	+6 lines, -5 lines	0 comments	Download
M	ui/aura/desktop/desktop_activation_client.h	View	1 2 3	1 chunk	+2 lines, -1 line	0 comments	Download
M	ui/aura/desktop/desktop_activation_client.cc	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
D	ui/aura/event.h	View	1 2 3	1 chunk	+0 lines, -400 lines	0 comments	Download
D	ui/aura/event.cc	View	1 2 3	1 chunk	+0 lines, -479 lines	0 comments	Download
M	ui/aura/event_filter.h	View	1 2 3	2 chunks	+13 lines, -9 lines	0 comments	Download
M	ui/aura/event_filter_unittest.cc	View	1 2 3	3 chunks	+7 lines, -6 lines	0 comments	Download
D	ui/aura/event_mac.h	View	1 2 3	1 chunk	+0 lines, -18 lines	0 comments	Download
D	ui/aura/event_mac.mm	View	1 2 3	1 chunk	+0 lines, -15 lines	0 comments	Download
D	ui/aura/event_unittest.cc	View	1 2 3	1 chunk	+0 lines, -116 lines	0 comments	Download
M	ui/aura/focus_manager.h	View	1 2 3	2 chunks	+5 lines, -2 lines	0 comments	Download
M	ui/aura/focus_manager.cc	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	ui/aura/gestures/gesture_recognizer_unittest.cc	View	1 2 3	101 chunks	+284 lines, -280 lines	0 comments	Download
M	ui/aura/root_window.h	View	1 2 3	6 chunks	+19 lines, -18 lines	0 comments	Download
M	ui/aura/root_window.cc	View	1 2 3	21 chunks	+49 lines, -38 lines	0 comments	Download
M	ui/aura/root_window_host_delegate.h	View	1 2 3	1 chunk	+11 lines, -8 lines	0 comments	Download
M	ui/aura/root_window_host_linux.cc	View	1 2 3	6 chunks	+8 lines, -8 lines	0 comments	Download
M	ui/aura/root_window_host_win.cc	View	1 2 3	3 chunks	+3 lines, -3 lines	0 comments	Download
M	ui/aura/root_window_unittest.cc	View	1 2 3	15 chunks	+34 lines, -31 lines	0 comments	Download
M	ui/aura/shared/compound_event_filter.h	View	1 2 3	3 chunks	+25 lines, -19 lines	0 comments	Download
M	ui/aura/shared/compound_event_filter.cc	View	1 2 3	10 chunks	+33 lines, -35 lines	0 comments	Download
M	ui/aura/shared/compound_event_filter_unittest.cc	View	1 2 3	2 chunks	+7 lines, -5 lines	0 comments	Download
M	ui/aura/shared/input_method_event_filter.h	View	1 2 3	1 chunk	+10 lines, -11 lines	0 comments	Download
M	ui/aura/shared/input_method_event_filter.cc	View	1 2 3	5 chunks	+9 lines, -9 lines	0 comments	Download
M	ui/aura/test/event_generator.h	View	1 2 3	2 chunks	+5 lines, -2 lines	0 comments	Download
M	ui/aura/test/event_generator.cc	View	1 2 3	17 chunks	+32 lines, -28 lines	0 comments	Download
M	ui/aura/test/test_activation_client.h	View	1 2 3	1 chunk	+2 lines, -1 line	0 comments	Download
M	ui/aura/test/test_activation_client.cc	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	ui/aura/test/test_event_filter.h	View	1 2 3	1 chunk	+9 lines, -6 lines	0 comments	Download
M	ui/aura/test/test_event_filter.cc	View	1 2 3	1 chunk	+9 lines, -6 lines	0 comments	Download
M	ui/aura/test/test_window_delegate.h	View	1 2 3	3 chunks	+8 lines, -7 lines	0 comments	Download
M	ui/aura/test/test_window_delegate.cc	View	1 2 3	6 chunks	+9 lines, -8 lines	0 comments	Download
M	ui/aura/window.h	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	ui/aura/window.cc	View	1 2 3	6 chunks	+5 lines, -6 lines	0 comments	Download
M	ui/aura/window_delegate.h	View	1 2 3	3 chunks	+10 lines, -9 lines	0 comments	Download
M	ui/aura/window_unittest.cc	View	1 2 3	16 chunks	+30 lines, -27 lines	0 comments	Download
M	ui/base/event.h	View	1 2 3	2 chunks	+4 lines, -5 lines	0 comments	Download
M	ui/base/event.cc	View	1 2 3	3 chunks	+10 lines, -1 line	0 comments	Download
M	ui/gfx/native_widget_types.h	View	1 2 3	2 chunks	+4 lines, -2 lines	0 comments	Download
M	ui/views/controls/webview/web_dialog_view.cc	View	1 2 3	2 chunks	+2 lines, -2 lines	0 comments	Download
M	ui/views/drag_utils.cc	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	ui/views/events/event.h	View	1 2 3	2 chunks	+3 lines, -6 lines	0 comments	Download
M	ui/views/events/event_aura.cc	View	1 2 3	5 chunks	+11 lines, -10 lines	0 comments	Download
M	ui/views/view_unittest.cc	View	1 2 3	1 chunk	+0 lines, -1 line	0 comments	Download
M	ui/views/widget/desktop_native_widget_helper_aura.cc	View	1 2 3	2 chunks	+3 lines, -3 lines	0 comments	Download
M	ui/views/widget/native_widget_aura.h	View	1 2 3	2 chunks	+9 lines, -8 lines	0 comments	Download
M	ui/views/widget/native_widget_aura.cc	View	1 2 3	8 chunks	+12 lines, -11 lines	0 comments	Download
M	ui/views/widget/native_widget_aura_unittest.cc	View	1 2 3	5 chunks	+9 lines, -9 lines	0 comments	Download
M	ui/views/widget/tooltip_manager_aura.cc	View	1 2 3	2 chunks	+2 lines, -2 lines	0 comments	Download
M	ui/views/widget/widget_message_filter.cc	View	1 2 3	1 chunk	+0 lines, -1 line	0 comments	Download
M	ui/views/widget/x11_window_event_filter.h	View	1 2 3	2 chunks	+6 lines, -6 lines	0 comments	Download
M	ui/views/widget/x11_window_event_filter.cc	View	1 2 3	3 chunks	+5 lines, -4 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ben@chromium.org/10827145/7501

8 years, 4 months ago (2012-08-08 01:30:29 UTC) #3

commit-bot: I haz the power

Failed to apply patch for ash/magnifier/magnification_controller.cc: While running patch -p0 --forward --force; patching file ash/magnifier/magnification_controller.cc ...

8 years, 4 months ago (2012-08-08 01:31:05 UTC) #4

content/renderer lgtm

Expand Messages | Collapse Messages